Add shouldRejectTrailingBytes test for messages #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
So I messed up in #150. I didn't notice that
RlpUtil#readRlpList
callscheckComplete
. Sorry about that.https://github.com/ConsenSys/discovery/blob/9bb8ad3942f81450fe54a78c66f0b61e58c45b0b/src/main/java/org/ethereum/beacon/discovery/util/RlpUtil.java#L39-L47
This PR will:
checkComplete
calls.assertRoundTrip
andassertRejectTrailingBytes
toTestUtil
.shouldRejectTrailingBytes
test.shouldRoundTrip
withassertRoundTrip
.Also, unrelated to the core part of this PR:
TAUthData
->TAuthData
) inHeaderImpl
.it's
vsits
in comments.