feat: wrap existing hash-to-field for implementing hash.Hash interface #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We already provide default hash-to-field in fp and fr packages. However, right now it is only a method, but it would be beneficial if we would be able to implement
hash.Hash
(from Gocrypto/hash
) so that we can have custom hash-to-field functions in gnark. This PR adds the wrapper such that the output is equal to naively callingfr.Hash
on the same byte slice input. Also add a basic test.Related to Consensys/gnark#847 as we would need to be able to swap hash-to-field in Plonk prover and verifier.
Type of change
How has this been tested?
fr.Hash
output.How has this been benchmarked?
Not benchmarked.
Checklist:
golangci-lint
does not output errors locally