-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom hash function in backends #873
Conversation
📦
|
13581ee
to
335f801
Compare
📦 📦 📦
📦
📦 📦
📦
📦 📦
📦
📦 📦
📦
📦 📦
📦
📦 📦
📦
📦 📦
📦
📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 📦 |
335f801
to
6b7934a
Compare
Description
This PR implements:
For this, I added verifier and prover options for setting the hash functions. Additionally, I also added a way to modify verifier configuration using the assertion framework.
When the prover or verifier configuration is not modified then we are using exactly the same hash functions as before, so the proofs should be backwards compatible and most importantly, compatible with the Solidity verifer.
NB! Before merging we should get Consensys/gnark-crypto#464 merged and update the dependencies. Right now in
go.mod
I'm using the commit from the PR, but it would be better to use a commit from the master branch to avoid conflicts.Related #847
Type of change
How has this been tested?
How has this been benchmarked?
Not benchmarked.
Checklist:
golangci-lint
does not output errors locally