MODEXP flag sums and NSR sums fixes #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBBB
changed the title
OlivierBBB
commented
Dec 9, 2024
| )) | ||
| ;; MODEXP flag sum shorthands | ||
| (defun (precompile-processing---flag-sum-MODEXP-FKTR) (precompile-processing---flag-sum-standard-failure)) | ||
| (defun (precompile-processing---flag-sum-MODEXP-success) (precompile-processing---flag-sum-standard-success)) |
There was a problem hiding this comment.
In the above there was a mix-up: shorthands that were pointing to flag-sum's were labeled as nsr and the flag sums were completely wrong (wrt MODEXP)
In terms of flag sums they are now correctly defined as
new (precompile-processing---flag-sum-MODEXP-FKTR) <- old (precompile-processing---nsr-MODEXP-FKTR)
new (precompile-processing---flag-sum-MODEXP-success) <- old (precompile-processing---nsr-MODEXP-success) and in terms of the NSR sums
new (precompile-processing---2nd-half-NSR-for-MODEXP)
<- linear combination of
- precompile-processing---MODEXP-nsr-FKTR
- precompile-processing---MODEXP-nsr-success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.