Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODEXP flag sums and NSR sums fixes #540

Merged
merged 1 commit into from
Dec 9, 2024
+32 −37
Merged

MODEXP flag sums and NSR sums fixes #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 32 additions & 37 deletions hub/constraints/instruction-handling/call/precompiles/flag_sums_and_NSRs.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,42 +184,40 @@
(defun (precompile-processing---2nd-half-flag-sum-for-MODEXP)
(+ (* (precompile-processing---flag-sum-MODEXP-FKTR) scenario/PRC_FAILURE_KNOWN_TO_RAM)
(* (precompile-processing---flag-sum-MODEXP-success) (scenario-shorthand---PRC---success))
))
))
;; MODEXP non stack rows
(defun (precompile-processing---2nd-half-NSR-for-MODEXP)
(+ (* (precompile-processing---nsr-MODEXP-FKTR) scenario/PRC_FAILURE_KNOWN_TO_RAM)
(* (precompile-processing---nsr-MODEXP-success) (scenario-shorthand---PRC---success))
))
(defconst precompile-processing---MODEXP-nsr-FKTR 8)
(defconst precompile-processing---MODEXP-nsr-success 13)
(defun (precompile-processing---2nd-half-NSR-for-MODEXP)
(+ (* precompile-processing---MODEXP-nsr-FKTR scenario/PRC_FAILURE_KNOWN_TO_RAM)
(* precompile-processing---MODEXP-nsr-success (scenario-shorthand---PRC---success))
))
;; MODEXP non stack rows shorthands
(defun (precompile-processing---nsr-MODEXP-FKTR) (+
(shift PEEK_AT_SCENARIO 0 )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---cds---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-bbs---offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-ebs---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-mbs---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-raw-lead---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---pricing---row-offset )
(shift PEEK_AT_CONTEXT precompile-processing---MODEXP-context-row---FKTR---row-offset )
)
)
(defun (precompile-processing---nsr-MODEXP-success) (+
(shift PEEK_AT_SCENARIO 0 )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---cds---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-bbs---offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-ebs---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-mbs---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-raw-lead---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---pricing---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---copy-inputs-base---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---copy-inputs-exponent---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---copy-inputs-modulus---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---full-result-transfer---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---partial-result-copy---row-offset )
(shift PEEK_AT_CONTEXT precompile-processing---MODEXP-context-row---success---row-offset )
))
;; MODEXP flag sum shorthands
(defun (precompile-processing---flag-sum-MODEXP-FKTR) (precompile-processing---flag-sum-standard-failure))
(defun (precompile-processing---flag-sum-MODEXP-success) (precompile-processing---flag-sum-standard-success))
Copy link
Collaborator Author

@OlivierBBB OlivierBBB Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the above there was a mix-up: shorthands that were pointing to flag-sum's were labeled as nsr and the flag sums were completely wrong (wrt MODEXP)

In terms of flag sums they are now correctly defined as

new (precompile-processing---flag-sum-MODEXP-FKTR)     <-  old (precompile-processing---nsr-MODEXP-FKTR)
new (precompile-processing---flag-sum-MODEXP-success)  <-  old (precompile-processing---nsr-MODEXP-success)

and in terms of the NSR sums

new (precompile-processing---2nd-half-NSR-for-MODEXP)
    <-  linear combination of
        - precompile-processing---MODEXP-nsr-FKTR
        - precompile-processing---MODEXP-nsr-success

(defun (precompile-processing---flag-sum-MODEXP-FKTR) (+
(shift PEEK_AT_SCENARIO 0 )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---cds---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-bbs---offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-ebs---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-mbs---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-raw-lead---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---pricing---row-offset )
(shift PEEK_AT_CONTEXT precompile-processing---MODEXP-context-row---FKTR---row-offset )
))
(defun (precompile-processing---flag-sum-MODEXP-success) (+
(shift PEEK_AT_SCENARIO 0 )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---cds---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-bbs---offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-ebs---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-mbs---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---extract-raw-lead---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---pricing---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---copy-inputs-base---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---copy-inputs-exponent---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---copy-inputs-modulus---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---full-result-transfer---row-offset )
(shift PEEK_AT_MISCELLANEOUS precompile-processing---MODEXP-misc-row---partial-result-copy---row-offset )
(shift PEEK_AT_CONTEXT precompile-processing---MODEXP-context-row---success---row-offset )
))
;; NB: the failure scenario FAILURE_KNOWN_TO_HUB is impossible
(defconst
precompile-processing---MODEXP-misc-row---cds---row-offset 1
Expand All @@ -236,9 +234,6 @@

precompile-processing---MODEXP-context-row---FKTR---row-offset 7
precompile-processing---MODEXP-context-row---success---row-offset 12

precompile-processing---nsr-FKTR 8
precompile-processing---nsr-success 13
)


Expand Down
Loading