[Merge] Adjust ExecutionPayload.transaction type with new Transaction Union structure #4362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Sep 14, 2021
...ence-tests/src/referenceTest/java/tech/pegasys/teku/reference/ManualReferenceTestRunner.java
Outdated
Show resolved
Hide resolved
|
Confirmed this gets all the ssz_static reference tests passing which is great. |
…-transaction-type # Conflicts: # ssz/src/main/java/tech/pegasys/teku/ssz/impl/SszUnionImpl.java # ssz/src/main/java/tech/pegasys/teku/ssz/schema/SszUnionSchema.java # ssz/src/main/java/tech/pegasys/teku/ssz/schema/impl/SszUnionSchemaImpl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR based on top of #4361
TransactionUnion structure for cleaner codeExecutionPayload.transactionwith typeSszList<Transaction>Fixed Issue(s)
Part of #4226
Reduces number of failing ref tests from 633 to 170
Documentation
documentationlabel to this PR if updates are required.Changelog