Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge] Fix reference tests #4368

Merged
merged 3 commits into from
Sep 15, 2021
Merged

[Merge] Fix reference tests #4368

merged 3 commits into from
Sep 15, 2021

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Sep 15, 2021 •
edited
Loading

PR Description

Makes progress fixing failing merge reference tests.

  • Fix SpecConfigMerge so it implements SpecConfigAltair and doesn't get unwrapped when calling toVersionAltair()
  • Suport sync aggregates in merge block processor
  • Use altair versions of beacon chain accessor and mutator
  • Use altair version of rewards & penalties reference test executor

Combined with #4362 this gets all reference tests passing.

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@ajsutton
Make progress fixing reference tests
b95d051 
* Fix SpecConfigMerge so it implements SpecConfigAltair and toVersionAltair() still returns the merge instance instead of unwrapping
* Support sync aggregate in merge block processing
@ajsutton
Use altair beacon state accessors and mutators.
fac22c8 
Use altair rewards test runner.
@ajsutton ajsutton changed the title [Merge] Start fixing reference tests [Merge] Fix reference tests Sep 15, 2021
@Nashatyrev Nashatyrev mentioned this pull request Sep 15, 2021
Closed
20 tasks
Nashatyrev
Nashatyrev approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashatyrev Nashatyrev merged commit 5fb39ce into Consensys:merge-interop Sep 15, 2021
@ajsutton ajsutton deleted the fix-ref-tests1 branch September 15, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashatyrev Nashatyrev Nashatyrev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajsutton @Nashatyrev