Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge] Dont't send INVALID consensusValidated() when executePayload() returns SYNCING #4456

Conversation

Nashatyrev
Copy link
Contributor

PR Description

This is mostly a quick dirty fix. I'm even not sure on how to correctly handle SYNCING response on block import.

Fixed Issue(s)

Part of #4226

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit 4e227fe into Consensys:merge-interop Oct 7, 2021
@Nashatyrev Nashatyrev deleted the merge/fix/consensus-validated-on-syncing branch November 18, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants