Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge] Draft implementation of Optimistic sync with Execution Layer #4458

Merged

Conversation

Nashatyrev
Copy link
Contributor

@Nashatyrev Nashatyrev commented Oct 7, 2021

PR Description

Based on top of #4456

Kind of quick fix to support the Optimistic syncing:

  • Assume all 'old' blocks (block.slot < currentSlot - 128) as 'finalized' which need no executionPayload and checkOnTerminalPowBlockConditions validation
  • Validating all the 'recent' blocks as per spec

The general idea of production implementation is to queue those validations while syncing, drop validations for blocks which become finalized, execute the remaining validations when the sync completes. Probably makes sense to update the head upon EL validations pass

Related Lighthouse PRs:

Related doc: https://notes.ethereum.org/@djrtwo/BJxKBaqNF

Good description here as well: sigp/lighthouse#2691

Fixed Issue(s)

Part of #4226

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@Nashatyrev Nashatyrev marked this pull request as ready for review October 7, 2021 15:00
…imistic-sync-baseline

# Conflicts:
#	ethereum/spec/src/main/java/tech/pegasys/teku/spec/logic/versions/merge/block/BlockProcessorMerge.java
@Nashatyrev Nashatyrev changed the title Merge/optimistic sync baseline [Merge] Draft implementation of Optimistic sync with Execution Layer Oct 7, 2021
@Nashatyrev Nashatyrev mentioned this pull request Oct 7, 2021
20 tasks
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit 1750164 into Consensys:merge-interop Oct 7, 2021
@Nashatyrev Nashatyrev deleted the merge/optimistic-sync-baseline branch November 18, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants