Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-6110 Implement beacon-chain and validator logic #8124

Merged

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Mar 21, 2024

PR Description

As per ethereum/consensus-specs#3615

  • Also removed incorrect tests in BlockProcessor...Test

Main changes are in BlockProcessorElectra and DepositProvider

Fixed Issue(s)

solves 2 of the tasks under #7898

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov changed the title EIP-6110 Implement beacon-chain and validator logic EIP-6110 Implement beacon-chain and validator logic Mar 21, 2024
@lucassaldanha lucassaldanha self-requested a review March 21, 2024 23:16
@StefanBratanov StefanBratanov force-pushed the block_processing_logic_6110 branch 2 times, most recently from e7f7a81 to 39cef38 Compare March 22, 2024 15:22
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one test improvement could be good if it's not complex

@StefanBratanov StefanBratanov enabled auto-merge (squash) March 25, 2024 15:20
@StefanBratanov StefanBratanov merged commit 6bad944 into Consensys:master Mar 25, 2024
15 of 16 checks passed
@StefanBratanov StefanBratanov deleted the block_processing_logic_6110 branch April 3, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants