-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-6110 Implement beacon-chain
and validator
logic
#8124
Merged
StefanBratanov
merged 13 commits into
Consensys:master
from
StefanBratanov:block_processing_logic_6110
Mar 25, 2024
Merged
EIP-6110 Implement beacon-chain
and validator
logic
#8124
StefanBratanov
merged 13 commits into
Consensys:master
from
StefanBratanov:block_processing_logic_6110
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
changed the title
EIP-6110 Implement beacon-chain and validator logic
EIP-6110 Implement Mar 21, 2024
beacon-chain
and validator
logic
StefanBratanov
force-pushed
the
block_processing_logic_6110
branch
from
March 21, 2024 17:38
e57ddc7
to
5c21ba6
Compare
StefanBratanov
force-pushed
the
block_processing_logic_6110
branch
2 times, most recently
from
March 22, 2024 15:22
e7f7a81
to
39cef38
Compare
zilm13
reviewed
Mar 24, 2024
ethereum/spec/src/main/java/tech/pegasys/teku/spec/datastructures/util/DepositReceiptsUtil.java
Outdated
Show resolved
Hide resolved
...test/java/tech/pegasys/teku/spec/logic/versions/electra/block/BlockProcessorElectraTest.java
Outdated
Show resolved
Hide resolved
.../test/java/tech/pegasys/teku/spec/logic/versions/electra/helpers/MiscHelpersElectraTest.java
Show resolved
Hide resolved
beacon/validator/src/test/java/tech/pegasys/teku/validator/coordinator/DepositProviderTest.java
Show resolved
Hide resolved
StefanBratanov
force-pushed
the
block_processing_logic_6110
branch
from
March 25, 2024 09:49
cd5f8c0
to
f93db17
Compare
zilm13
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one test improvement could be good if it's not complex
ethereum/spec/src/test/java/tech/pegasys/teku/spec/logic/common/helpers/MiscHelpersTest.java
Outdated
Show resolved
Hide resolved
StefanBratanov
force-pushed
the
block_processing_logic_6110
branch
from
March 25, 2024 15:03
191ecd5
to
6e397ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As per ethereum/consensus-specs#3615
Main changes are in
BlockProcessorElectra
andDepositProvider
Fixed Issue(s)
solves 2 of the tasks under #7898
Documentation
doc-change-required
label to this PR if updates are required.Changelog