Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init Electra (EIP6110 + EIP7002) #3615

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Init Electra (EIP6110 + EIP7002) #3615

merged 8 commits into from
Apr 9, 2024

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Mar 6, 2024 •
edited
Loading

Merged EIP6110 and EIP7002 specs into new Electra specs.

/cc @djrtwo

dapplion
dapplion reviewed Mar 11, 2024
View reviewed changes
specs/electra/beacon-chain.md

## Containers

### New containers

#### `DepositReceipt`

*Note*: The container is new in EIP6110.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note can be inferred from

 deposit_receipts: List[DepositReceipt, MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD]  # [New in Electra:EIP6110]`

not sure if it's worth the percent and now we may have to annotate all containers

mkalinin
mkalinin reviewed Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for a couple of nits!

fork.md still refers to EIP-6110: "This document describes the process of EIP-6110 upgrade.” (couldn’t make a proper link to this line)

specs/electra/beacon-chain.md Outdated Show resolved Hide resolved
djrtwo
djrtwo approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

This was referenced Mar 19, 2024
Merged
Merged
@StefanBratanov
Copy link
Contributor

I raised a small PR #3629 for an EIP-6110 function rename. I am not sure if a comment here would have been more appropriate.

@hwwhww hwwhww mentioned this pull request Mar 26, 2024
Merged
lucassaldanha
lucassaldanha approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@hwwhww hwwhww marked this pull request as ready for review April 4, 2024 22:11
hwwhww
hwwhww commented Apr 4, 2024
View reviewed changes
presets/mainnet/electra.yaml Outdated Show resolved Hide resolved
@hwwhww @mkalinin
Apply suggestions from code review
e64afbc 
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
@ralexstokes ralexstokes mentioned this pull request Apr 5, 2024
Merged
1 task
@lucassaldanha lucassaldanha mentioned this pull request Apr 7, 2024
Merged
2 tasks
@hwwhww hwwhww merged commit aba6345 into dev Apr 9, 2024
28 of 29 checks passed
@hwwhww hwwhww deleted the init-electra branch April 9, 2024 03:43
@ralexstokes ralexstokes mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion left review comments

@mkalinin mkalinin mkalinin left review comments

@khademreza5 khademreza5 khademreza5 approved these changes

@lucassaldanha lucassaldanha lucassaldanha approved these changes

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE Electra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hwwhww @StefanBratanov @djrtwo @lucassaldanha @mkalinin @dapplion @khademreza5