-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8767 update payload attributes #8824
8767 update payload attributes #8824
Conversation
f8ee637
to
83f14de
Compare
networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/peers/DefaultEth2Peer.java
Outdated
Show resolved
Hide resolved
0ca5247
to
1c218a9
Compare
1c218a9
to
fbf45ae
Compare
fix and add some tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nits, but I don't understand which spec update is implemented. The one linked doesn't have TARGET
parameter and is tied with EIP7594
rather than ELECTRA
ethereum/spec/src/main/java/tech/pegasys/teku/spec/config/SpecConfigDenebImpl.java
Outdated
Show resolved
Hide resolved
ethereum/spec/src/main/java/tech/pegasys/teku/spec/config/SpecConfigDenebImpl.java
Outdated
Show resolved
Hide resolved
.../networking/eth2/rpc/beaconchain/methods/BlobSidecarsByRangeListenerValidatingProxyTest.java
Show resolved
Hide resolved
Per my understanding peerDas will use a similar approach (via EIP7594 postfix) but we will do a similar thing for ELECTRA too (this PR is anticipating it essentially) |
PR Description
Use the new
TARGET_BLOBS_PER_BLOCK_ELECTRA
andMAX_BLOBS_PER_BLOCK_ELECTRA
params in thePayloadBuildingAttributes
.let the new param be unchanged so that reference tests do not fail
Fixed Issue(s)
addresses all changes required by #8767, the only remaining thing is changing the actual values when they will be changed on spec
In particular this PR is related to:
ethereum/execution-apis#574
ethereum/consensus-specs#3800
Documentation
doc-change-required
label to this PR if updates are required.Changelog