changes required for EIP-7742 #574

ralexstokes · 2024-08-21T21:57:39Z

see motivation etc here: ethereum/consensus-specs#3800

src/engine/prague.md

g11tech

lgtm

g11tech · 2024-10-19T11:16:28Z

actually i think we might need to add baseFeePerBlobGas in beacon's execution header and hence the api field, because the blob gas price can't just be now : minFee* e^(ecessBlobGasg/blobGasPriceUpdateFraction) since blobGasPriceUpdateFraction (for limiting change 1+-1.125 factor) could change block to block.

so we should return to the normal pricing mechanism like basefee, so blobBaseFee = parent.blobBaseFee * e^((blobGasUsed - targetBlobGas)/blockAdjustedTargetFraction))

where blockAdjustedTargetFraction makes sure fee doesn't "change" by 1.125 either direction and is calculated block to block.

so in EL block header, we now remove excessBlobGas and add three fields: baseFeePerBlobGas, targetBlobGas and maxBlobGas (since we don't want this to be a hardfork based setting anymore as well, and don't want to keep a static fraction between target and max for better control over the blob throughput and bandwidth params), and beacon execution header we just add baseFeePerBlobGas

if it makes sense i could update the EIP 7742 with the gas calc changes and introducing the new fields

siladu · 2024-10-28T05:49:12Z

Updated eth Block schema as well: #601

ppopth · 2024-10-30T17:19:28Z

src/engine/prague.md

@@ -103,6 +108,18 @@ This structure has the syntax of [`ExecutionPayloadBodyV1`](./shanghai.md#execut
 - `withdrawalRequests`: `Array of WithdrawalRequestV1` - Array of withdrawal requests, each object is an `OBJECT` containing the fields of a `WithdrawalRequestV1` structure.
 - `consolidationRequests`: `Array of ConsolidationRequestV1` - Array of consolidation requests, each object is an `OBJECT` containing the fields of a `ConsolidationRequestV1` structure.

+### PayloadAttributesV4
+
+This structure has the syntax of `PayloadAttributesV3` and appends the fields: `targetBlobCount`, `maximumBlobCount`.


Suggested change

This structure has the syntax of `PayloadAttributesV3` and appends the fields: `targetBlobCount`, `maximumBlobCount`.

This structure has the syntax of `PayloadAttributesV3` and appends the fields: `targetBlobsPerBlock`, `maxBlobsPerBlock`.

ppopth · 2024-10-30T17:20:13Z

src/engine/prague.md

+- `targetBlobCount`: `QUANTITY`, 64 Bits - Average number of blobs to include per payload.
+- `maximumBlobCount`: `QUANTITY`, 64 Bits - Maximum number of blobs allowed per payload.


Suggested change

- `targetBlobCount`: `QUANTITY`, 64 Bits - Average number of blobs to include per payload.

- `maximumBlobCount`: `QUANTITY`, 64 Bits - Maximum number of blobs allowed per payload.

- `targetBlobsPerBlock`: `QUANTITY`, 64 Bits - Average number of blobs to include per payload.

- `maxBlobsPerBlock`: `QUANTITY`, 64 Bits - Maximum number of blobs allowed per payload.

ppopth · 2024-10-30T17:20:37Z

src/engine/prague.md

@@ -116,6 +133,7 @@ The request of this method is updated with [`ExecutionPayloadV4`](#ExecutionPayl
  1. `executionPayload`: [`ExecutionPayloadV4`](#ExecutionPayloadV4).
  2. `expectedBlobVersionedHashes`: `Array of DATA`, 32 Bytes - Array of expected blob versioned hashes to validate.
  3. `parentBeaconBlockRoot`: `DATA`, 32 Bytes - Root of the parent beacon block.
+  4. `targetBlobCount`: `QUANTITY`, 64 Bits - Average number of blobs to include per payload.


Suggested change

4. `targetBlobCount`: `QUANTITY`, 64 Bits - Average number of blobs to include per payload.

4. `targetBlobsPerBlock`: `QUANTITY`, 64 Bits - Average number of blobs to include per payload.

ppopth · 2024-10-30T17:31:33Z

src/engine/prague.md

+
+#### Response
+
+Refer to the response for [`engine_forkchoiceUpdatedV3`](./shanghai.md#engine_forkchoiceupdatedv3).


Suggested change

Refer to the response for [`engine_forkchoiceUpdatedV3`](./shanghai.md#engine_forkchoiceupdatedv3).

Refer to the response for [`engine_forkchoiceUpdatedV3`](./cancun.md#engine_forkchoiceupdatedv3).

ppopth · 2024-10-30T17:31:59Z

src/engine/prague.md

+
+#### Specification
+
+This method follows the same specification as [`engine_forkchoiceUpdatedV3`](./shanghai.md#engine_forkchoiceupdatedv3).


Suggested change

This method follows the same specification as [`engine_forkchoiceUpdatedV3`](./shanghai.md#engine_forkchoiceupdatedv3).

This method follows the same specification as [`engine_forkchoiceUpdatedV3`](./cancun.md#engine_forkchoiceupdatedv3).

klkvr · 2024-10-31T16:50:26Z

src/engine/prague.md

+
+Refer to the response for [`engine_forkchoiceUpdatedV3`](./shanghai.md#engine_forkchoiceupdatedv3).
+
+#### Specification


shouldn't this state that for payloadAttributes, timestamp must be within Prague hardfork?

ensi321 · 2024-11-19T09:47:25Z

Would probably want to rebase this so that targetBlobsPerBlock(targetBlobCount?) is placed after executionRequests in the param of engine_newPayloadV4

changes required for EIP-7742

7e57676

ralexstokes mentioned this pull request Aug 21, 2024

EIP-7742: Uncouple blob limits per block across CL and EL ethereum/consensus-specs#3800

Open

lightclient reviewed Aug 22, 2024

View reviewed changes

src/engine/prague.md Show resolved Hide resolved

provide maximumBlobCount for payload construction

ec49a5f

tbenr mentioned this pull request Oct 17, 2024

EIP-7742: Implement engine_forkChoiceUpdateV4 Consensys/teku#8743

Closed

lucassaldanha mentioned this pull request Oct 17, 2024

EIP-7742: Uncouple blob limits per block across CL and EL Consensys/teku#8745

Closed

philknows mentioned this pull request Oct 18, 2024

Electra: Implement EIP7742: uncouple blob limits per block across CL and EL ChainSafe/lodestar#7176

Open

g11tech approved these changes Oct 19, 2024

View reviewed changes

g11tech mentioned this pull request Oct 19, 2024

Update EIP-7742: update the required EL headers and the gas fee mecha… ethereum/EIPs#8979

Closed

siladu mentioned this pull request Oct 22, 2024

EIP-7742 Uncouple blob count between CL and EL hyperledger/besu#7605

Open

tanishqjasoria mentioned this pull request Oct 22, 2024

EIP 7742 implementation NethermindEth/nethermind#7518

Open

16 tasks

siladu mentioned this pull request Oct 28, 2024

EIP-7742 - Add target_blob_count to Block schema #601

Open

ppopth reviewed Oct 30, 2024

View reviewed changes

siladu mentioned this pull request Oct 31, 2024

EIP-7742 Engine API Changes hyperledger/besu#7840

Draft

8 tasks

klkvr reviewed Oct 31, 2024

View reviewed changes

klkvr mentioned this pull request Oct 31, 2024

feat: EIP-7742 alloy-rs/alloy#1600

Open

3 tasks

tbenr mentioned this pull request Nov 15, 2024

8767 update payload attributes Consensys/teku#8824

Merged

2 tasks

spencer-tb mentioned this pull request Nov 20, 2024

feat(forks): payload attributes and forkchoice updated class methods ethereum/execution-spec-tests#958

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

changes required for EIP-7742 #574

changes required for EIP-7742 #574

ralexstokes commented Aug 21, 2024 •

edited

Loading

g11tech left a comment

g11tech commented Oct 19, 2024 •

edited

Loading

siladu commented Oct 28, 2024 •

edited

Loading

ppopth Oct 30, 2024 •

edited

Loading

ppopth Oct 30, 2024 •

edited

Loading

ppopth Oct 30, 2024

ppopth Oct 30, 2024

ppopth Oct 30, 2024

klkvr Oct 31, 2024

ensi321 commented Nov 19, 2024

	This structure has the syntax of `PayloadAttributesV3` and appends the fields: `targetBlobCount`, `maximumBlobCount`.
	This structure has the syntax of `PayloadAttributesV3` and appends the fields: `targetBlobsPerBlock`, `maxBlobsPerBlock`.

		- `targetBlobCount`: `QUANTITY`, 64 Bits - Average number of blobs to include per payload.
		- `maximumBlobCount`: `QUANTITY`, 64 Bits - Maximum number of blobs allowed per payload.

	4. `targetBlobCount`: `QUANTITY`, 64 Bits - Average number of blobs to include per payload.
	4. `targetBlobsPerBlock`: `QUANTITY`, 64 Bits - Average number of blobs to include per payload.


		#### Response

		Refer to the response for [`engine_forkchoiceUpdatedV3`](./shanghai.md#engine_forkchoiceupdatedv3).


		#### Specification

		This method follows the same specification as [`engine_forkchoiceUpdatedV3`](./shanghai.md#engine_forkchoiceupdatedv3).

changes required for EIP-7742 #574

Are you sure you want to change the base?

changes required for EIP-7742 #574

Conversation

ralexstokes commented Aug 21, 2024 • edited Loading

g11tech left a comment

Choose a reason for hiding this comment

g11tech commented Oct 19, 2024 • edited Loading

siladu commented Oct 28, 2024 • edited Loading

ppopth Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

ppopth Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

ppopth Oct 30, 2024

Choose a reason for hiding this comment

ppopth Oct 30, 2024

Choose a reason for hiding this comment

ppopth Oct 30, 2024

Choose a reason for hiding this comment

klkvr Oct 31, 2024

Choose a reason for hiding this comment

ensi321 commented Nov 19, 2024

ralexstokes commented Aug 21, 2024 •

edited

Loading

g11tech commented Oct 19, 2024 •

edited

Loading

siladu commented Oct 28, 2024 •

edited

Loading

ppopth Oct 30, 2024 •

edited

Loading

ppopth Oct 30, 2024 •

edited

Loading