-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Any message with blanket implementation #1926
Conversation
0ff12a1
to
42c1f23
Compare
I removed the |
I tend to agree. But can we move this consolidation to the wasmvm codebase somehow? I.e. deserialize "any" and "stargate" into a single field in the struct? This would create a cleaner JSON interface for a future where we have different host environments. |
I agree, that would be even better. It can be done, but I think only with a custom unmarshalling function in wasmvm (or by having both fields, but that seems a bit ugly). I'll prepare a PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready assuming we solve the "stargate"/"any" cases ion the Go side
8a9650a
to
304348b
Compare
Yes, this is ready. "stargate" / "any" handling is also ready in CosmWasm/wasmvm#468 |
Closes #1924