Stargate support #89
Closed
Stargate support #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariuszDepta
force-pushed
the
stargate-support
branch
from
f480f8b to
fd03c5b
Compare
DariuszDepta
force-pushed
the
stargate-support
branch
from
22a1b8c to
2e231fc
Compare
| value: msg.value, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we need this conversion? Multitest handles a CosmosMsg by the contract, so StargateMsg -> CosmosMsg is something the contract does
|
|
||
| pub trait Stargate: Module<ExecT = StargateMsg, QueryT = StargateQuery, SudoT = Empty> {} | ||
|
|
||
| pub type StargateAcceptingModule = AcceptingModule<StargateMsg, StargateQuery, Empty>; |
There was a problem hiding this comment.
Interesting approach. Stargate messages and queries are not really modules. But this seems to work fine with the current model.
When renaming "stargate" -> "any" (see e.g. CosmWasm/cosmwasm#1926) we can add an AnyMsg right in the CosmosMsg enum case instead of having the fields in the enum directly to make this easier for multitest.
DariuszDepta
force-pushed
the
stargate-support
branch
from
8745f94 to
9e87c79
Compare
DariuszDepta
force-pushed
the
stargate-support
branch
from
b69250d to
a65cced
Compare
DariuszDepta
force-pushed
the
stargate-support
branch
2 times, most recently
from
8f4f81e to
60389b4
Compare
DariuszDepta
force-pushed
the
stargate-support
branch
from
60389b4 to
6f70f3c
Compare
|
Closed in favour of #106. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling of
CosmosMsg::StargateandQueryRequest::Stargatemessages.Added support for external stargate module implementation.
Users may provide their custom stargate module with custom stargate message processing in tests.