Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple testing from app with an interface #1397

Merged
merged 1 commit into from
May 15, 2023
Merged

Decouple testing from app with an interface #1397

merged 1 commit into from
May 15, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented May 15, 2023

Better support for custom apps in in wasmd's ibctesting package

@alpe alpe requested a review from pinosu May 15, 2023 07:40
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1397 (0337c35) into main (4c906d5) will decrease coverage by 3.34%.
The diff coverage is 21.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   63.47%   60.14%   -3.34%     
==========================================
  Files          56       60       +4     
  Lines        6971     7557     +586     
==========================================
+ Hits         4425     4545     +120     
- Misses       2218     2676     +458     
- Partials      328      336       +8     
Impacted Files Coverage Δ
app/test_support.go 0.00% <0.00%> (ø)
x/wasm/client/cli/tx.go 13.22% <0.00%> (+2.72%) ⬆️
x/wasm/module.go 36.64% <0.00%> (-2.39%) ⬇️
x/wasm/types/events.go 0.00% <0.00%> (ø)
x/wasm/client/cli/gov_tx.go 14.42% <14.42%> (ø)
x/wasm/keeper/querier.go 71.80% <54.54%> (-0.27%) ⬇️
x/wasm/keeper/keeper.go 86.51% <62.50%> (-0.23%) ⬇️
x/wasm/keeper/relay.go 96.80% <85.71%> (+0.33%) ⬆️
app/app.go 86.30% <100.00%> (+0.02%) ⬆️
app/wasm.go 100.00% <100.00%> (ø)
... and 6 more

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit e36611a into main May 15, 2023
@pinosu pinosu added the backport/v0.3x Backport patches to sdk45 release branch label May 17, 2023
ruthishvitwit added a commit to ruthishvitwit/wasmd that referenced this pull request May 19, 2023
Decouple testing from app with an interface
alpe pushed a commit that referenced this pull request May 26, 2023
* Merge pull request #1397 from CosmWasm/ext_wasmibctesting

Decouple testing from app with an interface

* Feat : Trimmed label to prevent white spaces

* Fix: Made required nit changes

* Added test files to validate untrimmed labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.3x Backport patches to sdk45 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants