Feat : Trimmed label to prevent white spaces #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decouple testing from app with an interface
alpe
reviewed
May 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
+ Coverage 60.14% 60.15% +0.01%
==========================================
Files 60 60
Lines 7557 7559 +2
==========================================
+ Hits 4545 4547 +2
Misses 2676 2676
Partials 336 336
|
alpe
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1183
The aim of this pr is to prevent white spaces in labels by either silent trimming before storing or to fail when the label is not trimmed