Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gov v1beta1 dependencies and deprecated proposals (Backport) #1646

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Oct 2, 2023

Resolves #1608

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #1646 (650784d) into main (894076a) will increase coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
+ Coverage   55.96%   56.59%   +0.62%     
==========================================
  Files          64       62       -2     
  Lines        9062     8194     -868     
==========================================
- Hits         5072     4637     -435     
+ Misses       3546     3120     -426     
+ Partials      444      437       -7     
Files Coverage Δ
app/app.go 84.29% <ø> (ø)
x/wasm/types/codec.go 61.53% <ø> (+2.71%) ⬆️
x/wasm/types/test_fixtures.go 63.56% <ø> (-17.47%) ⬇️

... and 2 files with indirect coverage changes

@pinosu pinosu marked this pull request as ready for review October 2, 2023 15:24
@pinosu pinosu requested a review from alpe as a code owner October 2, 2023 15:24
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🏄

@pinosu pinosu merged commit e0da419 into main Oct 4, 2023
8 checks passed
@pinosu pinosu deleted the 1608-remove_govv1beta1_backport branch October 4, 2023 07:31
alpe added a commit that referenced this pull request Nov 14, 2023
alpe added a commit that referenced this pull request Nov 15, 2023
* Revert "Remove gov v1beta1 dependencies and deprecated proposals (#1646)"

This reverts commit e0da419.

* Rename legacy propsal files

* Ensure gov store support for v1beta1 types

* Linter

* Cleanup alias
mergify bot pushed a commit that referenced this pull request Nov 15, 2023
* Revert "Remove gov v1beta1 dependencies and deprecated proposals (#1646)"

This reverts commit e0da419.

* Rename legacy propsal files

* Ensure gov store support for v1beta1 types

* Linter

* Cleanup alias

(cherry picked from commit 2a82e35)

# Conflicts:
#	x/wasm/types/tx.pb.go
alpe added a commit that referenced this pull request Nov 15, 2023
* Fix gov v1beta1 support for legacy propsals (#1715)

* Revert "Remove gov v1beta1 dependencies and deprecated proposals (#1646)"

This reverts commit e0da419.

* Rename legacy propsal files

* Ensure gov store support for v1beta1 types

* Linter

* Cleanup alias

(cherry picked from commit 2a82e35)

# Conflicts:
#	x/wasm/types/tx.pb.go

* Rengenerate from proto; formatting

* Make test compile with v0.4x branch

---------

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated gov beta1 code from the repo
2 participants