-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gov v1beta1 dependencies and deprecated proposals (Backport) #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1646 +/- ##
==========================================
+ Coverage 55.96% 56.59% +0.62%
==========================================
Files 64 62 -2
Lines 9062 8194 -868
==========================================
- Hits 5072 4637 -435
+ Misses 3546 3120 -426
+ Partials 444 437 -7
|
alpe
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 🏄
alpe
added a commit
that referenced
this pull request
Nov 15, 2023
alpe
added a commit
that referenced
this pull request
Nov 15, 2023
* Fix gov v1beta1 support for legacy propsals (#1715) * Revert "Remove gov v1beta1 dependencies and deprecated proposals (#1646)" This reverts commit e0da419. * Rename legacy propsal files * Ensure gov store support for v1beta1 types * Linter * Cleanup alias (cherry picked from commit 2a82e35) # Conflicts: # x/wasm/types/tx.pb.go * Rengenerate from proto; formatting * Make test compile with v0.4x branch --------- Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1608