Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gov v1beta1 support for legacy propsals (backport #1715) #1716

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 15, 2023

This is an automatic backport of pull request #1715 done by Mergify.
Cherry-pick of 2a82e35 has failed:

  • manual fix of test + regenerating Go files from protobuf

* Revert "Remove gov v1beta1 dependencies and deprecated proposals (#1646)"

This reverts commit e0da419.

* Rename legacy propsal files

* Ensure gov store support for v1beta1 types

* Linter

* Cleanup alias

(cherry picked from commit 2a82e35)

# Conflicts:
#	x/wasm/types/tx.pb.go
@mergify mergify bot requested a review from alpe as a code owner November 15, 2023 07:30
@mergify mergify bot added the conflicts label Nov 15, 2023
@alpe alpe removed the conflicts label Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #1716 (c5c9252) into releases/v0.4x (56af873) will decrease coverage by 0.07%.
Report is 1 commits behind head on releases/v0.4x.
The diff coverage is 56.02%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           releases/v0.4x    #1716      +/-   ##
==================================================
- Coverage           57.65%   57.59%   -0.07%     
==================================================
  Files                  62       64       +2     
  Lines                8086     8772     +686     
==================================================
+ Hits                 4662     5052     +390     
- Misses               3039     3290     +251     
- Partials              385      430      +45     
Files Coverage Δ
x/wasm/types/codec.go 100.00% <100.00%> (ø)
x/wasm/keeper/proposal_handler_legacy.go 55.77% <55.77%> (ø)
x/wasm/types/proposal_legacy.go 53.56% <53.56%> (ø)

... and 4 files with indirect coverage changes

@alpe alpe merged commit 2d9c98f into releases/v0.4x Nov 15, 2023
15 of 16 checks passed
@alpe alpe deleted the mergify/bp/releases/v0.4x/pr-1715 branch November 15, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant