Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Stargate #293

Merged
merged 8 commits into from
Oct 29, 2020
Merged

Upgrade to Stargate #293

merged 8 commits into from
Oct 29, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Oct 27, 2020

Upgrade to cosmos-sdk 6e569e125571

Replaces #252

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #293 into master will decrease coverage by 56.90%.
The diff coverage is 37.05%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #293       +/-   ##
===========================================
- Coverage   74.15%   17.24%   -56.91%     
===========================================
  Files          27       34        +7     
  Lines        2364    10412     +8048     
===========================================
+ Hits         1753     1796       +43     
- Misses        488     8519     +8031     
+ Partials      123       97       -26     
Impacted Files Coverage Δ
x/wasm/internal/types/msg.go 64.63% <0.00%> (ø)
x/wasm/internal/types/msg.pb.go 0.55% <ø> (ø)
x/wasm/internal/types/params.go 58.33% <ø> (+1.41%) ⬆️
x/wasm/internal/types/proposal.go 89.36% <ø> (-5.94%) ⬇️
x/wasm/internal/types/proposal.pb.go 0.42% <ø> (ø)
x/wasm/internal/types/query.pb.go 0.71% <ø> (ø)
x/wasm/internal/types/query.pb.gw.go 0.00% <ø> (ø)
x/wasm/internal/types/test_fixtures.go 92.00% <ø> (-0.43%) ⬇️
x/wasm/internal/types/types.go 23.76% <ø> (-0.24%) ⬇️
x/wasm/internal/types/types.pb.go 0.77% <ø> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff37dc6...cd3f72e. Read the comment docs.

@alpe alpe changed the title Upgrade Stargate Upgrade to Stargate Oct 27, 2020
@ethanfrey
Copy link
Member

The cosmos-sdk branching is a mess. Where is this commit 6e569e125571 from?

https://github.com/cosmos/cosmos-sdk/releases/tag/v0.40.0-rc1 is 68a23c4, which would probably be the best to target now.

We cannot follow master (which may have non-0.40 breaking changes in it) and can only follow commits on release/v0.40.x branch (which luckily contains both v0.40.0-rc0 and v0.40.0-rc1).

@ethanfrey
Copy link
Member

ethanfrey commented Oct 27, 2020

Ow. "Refactor x/{gov, crisis} according to ADR 031". Yeah, this is Aaron's breaking change he is planning for 0.41.

You can only trust tagged releases. Never trust master. I am afraid you will have to redo a bit of this PR with that in mind. Hopefully not much 🙏

@ethanfrey
Copy link
Member

ethanfrey commented Oct 27, 2020

Okay, I pulled back on the cosmos-sdk commit and got this compiling with v0.40.0-rc1. I did no manual testing beyond make test and make build, but used simapp as a reference to resolve any compile issues

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

A bit of cleanup on the handler plugins, but generally ver nice job with this 🥇

app/app.go Show resolved Hide resolved
x/wasm/internal/keeper/handler_plugin.go Outdated Show resolved Hide resolved
x/wasm/internal/keeper/handler_plugin.go Outdated Show resolved Hide resolved
x/wasm/internal/keeper/proposal_handler.go Show resolved Hide resolved
x/wasm/internal/keeper/querier.go Show resolved Hide resolved
x/wasm/internal/keeper/reflect_test.go Show resolved Hide resolved
x/wasm/internal/keeper/reflect_test.go Show resolved Hide resolved
x/wasm/internal/keeper/test_common.go Show resolved Hide resolved
x/wasm/internal/keeper/staking_test.go Show resolved Hide resolved
x/wasm/internal/types/msg.proto Show resolved Hide resolved
@alpe alpe mentioned this pull request Oct 29, 2020
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ethanfrey
Copy link
Member

I would like to fix codecov or remove it (it seems rather useless and non-deterministic). But that is for another PR. Let's get this in 🚀 🚀

@ethanfrey ethanfrey merged commit 1846f62 into master Oct 29, 2020
@ethanfrey ethanfrey deleted the upgrade_stargate_rebased branch October 29, 2020 13:14
@ethanfrey ethanfrey restored the upgrade_stargate_rebased branch October 29, 2020 13:14
@alpe alpe deleted the upgrade_stargate_rebased branch November 5, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants