-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Stargate #293
Upgrade to Stargate #293
Conversation
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
===========================================
- Coverage 74.15% 17.24% -56.91%
===========================================
Files 27 34 +7
Lines 2364 10412 +8048
===========================================
+ Hits 1753 1796 +43
- Misses 488 8519 +8031
+ Partials 123 97 -26
Continue to review full report at Codecov.
|
The cosmos-sdk branching is a mess. Where is this commit https://github.com/cosmos/cosmos-sdk/releases/tag/v0.40.0-rc1 is We cannot follow master (which may have non-0.40 breaking changes in it) and can only follow commits on |
Ow. "Refactor x/{gov, crisis} according to ADR 031". Yeah, this is Aaron's breaking change he is planning for 0.41. You can only trust tagged releases. Never trust master. I am afraid you will have to redo a bit of this PR with that in mind. Hopefully not much 🙏 |
Okay, I pulled back on the cosmos-sdk commit and got this compiling with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
A bit of cleanup on the handler plugins, but generally ver nice job with this 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I would like to fix codecov or remove it (it seems rather useless and non-deterministic). But that is for another PR. Let's get this in 🚀 🚀 |
Upgrade to cosmos-sdk
6e569e125571
Replaces #252