Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #294

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Update README #294

merged 1 commit into from
Oct 29, 2020

Conversation

conr2d
Copy link
Contributor

@conr2d conr2d commented Oct 28, 2020

Update the command in README example for running with docker

@conr2d conr2d requested a review from alpe as a code owner October 28, 2020 07:37
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #294 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   74.15%   74.06%   -0.09%     
==========================================
  Files          27       27              
  Lines        2364     2364              
==========================================
- Hits         1753     1751       -2     
- Misses        488      489       +1     
- Partials      123      124       +1     
Impacted Files Coverage Δ
x/wasm/internal/keeper/keeper.go 89.57% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff37dc6...2d73819. Read the comment docs.

@alpe
Copy link
Contributor

alpe commented Oct 29, 2020

Thanks for the PR! The script name has changed, indeed. 💐

There is a big chunk of work in #293 and I want to avoid another rebase due to updates in master. Please bare with us for some more days before we can merge this.

@conr2d
Copy link
Contributor Author

conr2d commented Oct 29, 2020

@alpe Sure, thank you. :)

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you.

@ethanfrey ethanfrey merged commit a962736 into CosmWasm:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants