Update gas costs #636
Merged
Update gas costs #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
approved these changes
Oct 8, 2021
| @@ -27,12 +27,12 @@ const ( | |||
| // such as hardcoding them in contracts. | |||
| // | |||
| // Please note that all gas prices returned to wasmvm should have this multiplied. | |||
| DefaultGasMultiplier uint64 = 15_000_000 | |||
| DefaultGasMultiplier uint64 = 140_000_000 | |||
There was a problem hiding this comment.
Good changes.
I would add some text where this came from.
Minimally linking to the Benchmarking PR and the discussion.
(For these 3 items)
There was a problem hiding this comment.
There were links to the related issues above already. I added the link to the PR discussion.
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 60.21% 60.24% +0.03%
==========================================
Files 48 48
Lines 5313 5313
==========================================
+ Hits 3199 3201 +2
+ Misses 1889 1888 -1
+ Partials 225 224 -1
|
Hjordaan2002
approved these changes
Oct 11, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #566
resolves #631
Applies gas costs proposed in #634