Skip to content

[PROD-14034] Reduce loki query range to avoid rounding errors #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[PROD-14034] Reduce loki query range to avoid rounding errors #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/kotlin/com/cosmotech/api/loki/LokiService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ import com.fasterxml.jackson.databind.ObjectMapper
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory
import com.fasterxml.jackson.module.kotlin.readValue
import java.time.Instant
import kotlin.math.min
import kotlin.time.Duration
import kotlin.time.Duration.Companion.days
import org.json.JSONArray
import org.json.JSONObject
import org.springframework.http.HttpHeaders
Expand Down Expand Up @@ -60,9 +62,10 @@ class LokiService(private val csmPlatformProperties: CsmPlatformProperties) {
val lokiConfig = getLokiConfig()
val maxQueryLengthNano =
Duration.parse(lokiConfig.limitsConfig.maxQueryLength).inWholeNanoseconds
val queryLengthNano = min(maxQueryLengthNano, 1.days.inWholeNanoseconds)

val startTimeNano = startTime.toEpochMilli() * MILLI_TO_NANO
val endTimeNano = startTimeNano + maxQueryLengthNano
val endTimeNano = startTimeNano + queryLengthNano

val params = LinkedMultiValueMap<String, String>()
params.add("query", "{namespace=\"$namespace\",pod=\"$podName\",container=\"main\"}")
Expand Down Expand Up @@ -98,7 +101,7 @@ class LokiService(private val csmPlatformProperties: CsmPlatformProperties) {
logEntries.lastOrNull()?.let {
val newStartTime = it.getLong(0) + 1
params.set("start", newStartTime.toString())
params.set("end", (newStartTime + maxQueryLengthNano).toString())
params.set("end", (newStartTime + queryLengthNano).toString())
}
} while (logEntries.size >= lokiConfig.limitsConfig.maxEntriesLimitPerQuery)

Expand Down