[v12] packet forward middleware

[agouin]

Integrates v4 of https://github.com/strangelove-ventures/packet-forward-middleware into the transfer middleware stack to enable atomic multi-hop through Juno.

callback flow: hooks -> ics29 fee -> packet forward -> transfer module
send packet direction: transfer module -> packet forward -> hooks -> channel

ibctest e2e test here

[Reecepbcups]

Needs upgrade set in app/upgrades/v12

constants.go -> packetforwardtypes.StoreKey
and
upgrades.go -> keepers.PacketForwardKeeper.SetParams(ctx, packetforwardtypes.DefaultParams()) (very bottom)

Upgrade from v11 -> v12 worked for me after that

junod q ibc-router params --node http://localhost:26657
fee_percentage: "0.000000000000000000"

---

junod tx ibc-transfer transfer transfer channel-0 "juno1hj5fveer5cjtn4wd6wstzugjfdxzl0xps73ftl|transfer/channel-1:juno10c3slrqx3369mfsr9670au22zvq082jaej8ve4" 111ujuno $CHAIN_A_ARGS --packet-timeout-height 0-0

When I try locally, doesn't seem to actually work. hermes both ways. Could be me doing some wrong though.

Tx goes through (initial IBC send) then it returns back, never gets to other channel (normal ibc-transfers work to both).
Are there example bash scripts anywhere?

[agouin]

Upgrade from v11 -> v12 worked for me after that

Thank you, I applied those changes.

junod tx ibc-transfer transfer transfer channel-0 "juno1hj5fveer5cjtn4wd6wstzugjfdxzl0xps73ftl|transfer/channel-1:juno10c3slrqx3369mfsr9670au22zvq082jaej8ve4" 111ujuno $CHAIN_A_ARGS --packet-timeout-height 0-0

The packet forward middleware no longer uses an overloaded receiver. The migration is documented in this PR

We don't have example bash scripts, but you can run the packet forward middleware e2e test in ibctest and swap out for a local/remote juno image.

[faddat]

As implemented doesn't this break IBC hooks?

[faddat]

I will resolve this change request if I can figure out what the changes are doing here

[Reecepbcups]

As implemented doesn't this break IBC hooks?

@faddat - It does not break IBC-Hooks, seems to work just fine:

[faddat]

ok. I was about to do the check you've now done. lgtm