Andrew/pfm v4.0.3 #547
Merged
Andrew/pfm v4.0.3 #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
Reecepbcups,
vuong177 and
JakeHartnell
and removed request for
Reecepbcups and
vuong177
Reecepbcups
approved these changes
Feb 6, 2023
|
yeah lgtm, then merge to the other one -- just in case |
vuong177
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @agouin -- original PR:
Bump to official pfm v4.0.3 release
https://github.com/strangelove-ventures/packet-forward-middleware/releases/tag/v4.0.3
Also, fixes ICS4 middleware direction.
Middlewares need to wire up the ibctransfertypes.ICS4Wrapper so that they eventually pass through the IBC ChannelKeeper, otherwise the SendPacket and WriteAcknowledgement calls used within the middlewares will not be wired up to perform the action they intend to.
This makes the direction of the ICS4Wrappers (outbound) through the middlewares the opposite of the inbound middleware direction of the transferStack, as they were in #513
callback flow: hooks -> ics29 fee -> packet forward -> transfer module
send packet direction: transfer module -> packet forward -> ics29 fee -> hooks -> channel