Mobile files #1108
Merged
Mobile files #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canac
reviewed
Oct 2, 2024
Bundle sizes [mpdx-react]Compared against 21ae96b No significant changes found |
frett
approved these changes
Oct 2, 2024
canac
approved these changes
Oct 2, 2024
frett
reviewed
Oct 2, 2024
| @@ -4,7 +4,7 @@ | |||
| "details": [ | |||
| { | |||
| "appID": "DQ48D9BF2V.org.cru.mpdx", | |||
| "paths": ["/contacts/*", "/auth/mobile"] | |||
| "paths": ["/accountLists/*/contacts/*", "/auth/mobile"] | |||
There was a problem hiding this comment.
@levieggertcru I'm assuming including a wildcard in the middle of the apple-app-site-association path would work correctly for iOS?
There was a problem hiding this comment.
When researching, this is what I found I should do when it's a dynamic route. But I could be wrong.
There was a problem hiding this comment.
I just checked the Universal Links spec and the wildcard pattern is valid according to the spec.
frett
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I add the files which the MPDX mobile apps rely on.
These files will appear as
mpdx.org/.well-known/assetlinks.jsonmpdx.org/.well-known/apple-app-site-association.jsonChecklist: