Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile files #1108

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Mobile files #1108

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2bd2537
Mobile files
dr-bizz Oct 2, 2024
07c334f
fixup! Mobile files
dr-bizz Oct 2, 2024
34a2669
/accountLists/*/contacts/* covers all potential dynamic values.
dr-bizz Oct 2, 2024
8a3aff4
Fixing test that keeps failing on the PR tests
dr-bizz Oct 2, 2024
1b49520
Merge branch 'mobile-app-files' of https://github.com/CruGlobal/mpdx-…
dr-bizz Oct 2, 2024
6601a67
Adding /contacts/* back in for back support for old emails
dr-bizz Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions public/.well-known/apple-app-site-association.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"applinks": {
"apps": [],
"details": [
{
"appID": "DQ48D9BF2V.org.cru.mpdx",
"paths": ["/accountLists/*/contacts/*", "/auth/mobile"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levieggertcru I'm assuming including a wildcard in the middle of the apple-app-site-association path would work correctly for iOS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When researching, this is what I found I should do when it's a dynamic route. But I could be wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the Universal Links spec and the wildcard pattern is valid according to the spec.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @frett

}
]
}
}
12 changes: 12 additions & 0 deletions public/.well-known/assetlinks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[
{
"relation": ["delegate_permission/common.handle_all_urls"],
"target": {
"namespace": "android_app",
"package_name": "org.mpdx",
"sha256_cert_fingerprints": [
"1C:10:CC:D9:97:17:F4:D9:B7:16:37:7C:6C:48:ED:0E:CB:29:C1:F9:6B:8A:FF:B1:E5:23:E3:B9:15:2A:C1:8B"
]
}
}
]
7 changes: 2 additions & 5 deletions src/components/Task/Modal/Form/Inputs/SuggestedContactStatus/SuggestedContactStatus.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ describe('SuggestedContactStatus', () => {
});

it('renders suggested status when single contact and checks contact status with gql call', async () => {
const { getByText } = render(
const { findByText } = render(
<Components
suggestedContactStatus={StatusEnum.ContactForAppointment}
contactIds={['contact-1']}
Expand All @@ -122,11 +122,8 @@ describe('SuggestedContactStatus', () => {
},
});
});
await waitFor(() => {
expect(getByText("Change the contact's status to:")).toBeInTheDocument();
});

expect(getByText('Initiate for Appointment')).toBeInTheDocument();
expect(await findByText('Initiate for Appointment')).toBeInTheDocument();
});

it('does not send a ContactStatus graphql request when the current contacts status is provided', async () => {
Expand Down
Loading