-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update toc #35
update toc #35
Conversation
Need to update environment.yml and lock files with hub-image environment.yml so new imports will work. When run tutorial, still get this error for icepyx, hvplot and geoviews: boto3 also missing from the environment. |
The quality control action is not working the way we want. I can't find any of the spelling errors it is referencing. Please ignore it for now. The rest is good to go for now. Once we get the environment updated, I will add the tutorial into the jupyterbook via the toc. It has several library errors (hvplot, holoviews, geoviews, icepyx) still that should all be related to something wrong with bokeh.models.Box. I'm getting |
I have also now disabled the Repo2Docker and Repo2DockerPR Actions since our Docker image is now coming from the hub-image repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I suggest just reverting the env name change (I'll update the other file) and we can proceed with the merge. Might as well keep this moving quickly.
conda/environment.yml
Outdated
@@ -3,24 +3,112 @@ | |||
|
|||
# !!! If you are developing the website locally use the existing lock files | |||
# for your platform (`conda create --name cryocloud --file conda-linux-64.lock`) | |||
name: cryocloud | |||
|
|||
name: cryointhecloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry! When I updated this file in the hub image repo, it didn't have a name so I made one up, and used the longer version. But I didn't see you'd already named it, and didn't mean to override you :)
I actually like your shorter name better - let's keep your shorter one and use that instead! I can update the name in the other one. We'll be typing that often, might as well use something more concise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cryocloud is perfect
No description provided.