Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update toc #35

Merged
merged 12 commits into from
Nov 28, 2022
Merged

update toc #35

merged 12 commits into from
Nov 28, 2022

Conversation

tsnow03
Copy link
Member

@tsnow03 tsnow03 commented Nov 27, 2022

No description provided.

@tsnow03
Copy link
Member Author

tsnow03 commented Nov 27, 2022

Need to update environment.yml and lock files with hub-image environment.yml so new imports will work.

When run tutorial, still get this error for icepyx, hvplot and geoviews:
ImportError: cannot import name 'Box' from 'bokeh.models' (/srv/conda/envs/notebook/lib/python3.10/site-packages/bokeh/models/__init__.py)

boto3 also missing from the environment.

@tsnow03
Copy link
Member Author

tsnow03 commented Nov 28, 2022

The quality control action is not working the way we want. I can't find any of the spelling errors it is referencing. Please ignore it for now. The rest is good to go for now. Once we get the environment updated, I will add the tutorial into the jupyterbook via the toc. It has several library errors (hvplot, holoviews, geoviews, icepyx) still that should all be related to something wrong with bokeh.models.Box. ImportError: cannot import name 'Box' from 'bokeh.models' (/srv/conda/envs/notebook/lib/python3.10/site-packages/bokeh/models/__init__.py). boto3 should be the only missing package.

I'm getting AttributeError: 'list' object has no attribute 'minimum_rotated_rectangle' in the IS2_cloud_data_integration Notebook. @JessicaS11 Have you seen this icepyx Query .visualize_elevation() error? I'm using the Berkeley cloud to test the notebook and I'm wondering if it is an icepyx error or a package issue.

@tsnow03
Copy link
Member Author

tsnow03 commented Nov 28, 2022

I have also now disabled the Repo2Docker and Repo2DockerPR Actions since our Docker image is now coming from the hub-image repo.

Copy link
Contributor

@fperez fperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I suggest just reverting the env name change (I'll update the other file) and we can proceed with the merge. Might as well keep this moving quickly.

@@ -3,24 +3,112 @@

# !!! If you are developing the website locally use the existing lock files
# for your platform (`conda create --name cryocloud --file conda-linux-64.lock`)
name: cryocloud

name: cryointhecloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry! When I updated this file in the hub image repo, it didn't have a name so I made one up, and used the longer version. But I didn't see you'd already named it, and didn't mean to override you :)

I actually like your shorter name better - let's keep your shorter one and use that instead! I can update the name in the other one. We'll be typing that often, might as well use something more concise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cryocloud is perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants