Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update oa viz for polygons after spatial module change #390

Merged
merged 11 commits into from
Jan 27, 2023
Merged

Conversation

JessicaS11
Copy link
Member

@JessicaS11 JessicaS11 commented Dec 1, 2022

OpenAltimetry visualizations could not be requested for polygon spatial extents due to a missed type change required by the introduction of the spatial module and cross-dateline handling in #331.

The bug was originally documented here, and an inline fix can be found here.

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Binder 👈 Launch a binder notebook on this branch for commit be0527a

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit c9d8cfd

Binder 👈 Launch a binder notebook on this branch for commit bfdaed7

Binder 👈 Launch a binder notebook on this branch for commit 84577af

Binder 👈 Launch a binder notebook on this branch for commit 4eea849

Binder 👈 Launch a binder notebook on this branch for commit 9601a42

Binder 👈 Launch a binder notebook on this branch for commit a913b24

Binder 👈 Launch a binder notebook on this branch for commit f9af8c9

Binder 👈 Launch a binder notebook on this branch for commit 19a9e1e

@weiji14 weiji14 added the bug Something isn't working label Dec 2, 2022
@JessicaS11
Copy link
Member Author

JessicaS11 commented Jan 4, 2023

I'm still working on debugging the tests. The failure is coming from ATL13 queries that return no data (at the CMR query stage).

UPDATE: I'm working with NSIDC on this, but there's no clear explanation for what happened (the tests started failing seemingly randomly on 7 Nov). So we can move ahead with this PR and the important fix it contains, I've deactivated the tests and opened #399.

@JessicaS11 JessicaS11 linked an issue Jan 18, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Base: 57.57% // Head: 58.29% // Increases project coverage by +0.72% 🎉

Coverage data is based on head (19a9e1e) compared to base (6d7dde9).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #390      +/-   ##
===============================================
+ Coverage        57.57%   58.29%   +0.72%     
===============================================
  Files               31       31              
  Lines             2251     2247       -4     
  Branches           433      433              
===============================================
+ Hits              1296     1310      +14     
+ Misses             872      854      -18     
  Partials            83       83              
Impacted Files Coverage Δ
icepyx/core/visualization.py 73.17% <0.00%> (+10.07%) ⬆️
icepyx/tests/test_visualization.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JessicaS11 JessicaS11 merged commit 01facea into development Jan 27, 2023
@JessicaS11 JessicaS11 deleted the vizfix branch January 27, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reinstate ATL10 and ATL12 OA tests
3 participants