Cryoris consistent gate naming #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Acquire: AcquireInstruction change to sigle qbit, mem_slot, reg_slot * Acquire: change usage of AcquireInstruction * Tests: partial test fixing * Assembler: tweak scheduler assembler to laverage new acquire + tests fixes * Scheduler: fix scheduler to use acquire on single qubit + tests fix * Style: fix lint errors * Acquire: remove unecessary properties * Style: fix lint errors * Acuqire: back compatibility on acquire multiple qubits * Acuqire: fix linter * Acquire: refactor * Acquire: fix implicit acquires; todo: revisit _validate_meas_map method * Acquire: pylint fix * Acquire: minor fixes * Acquire: fix add implicits acquires function * Acquire: instruction properties fix * Acquire: remove test for validating meas map * Linter: fix errors * Acquire: style fix * Acquire: remove deprecation in acquires property + fix positional arguments * Acquire: back and forward compatibility * Acquire: remove deprecation warning (hm, I thought I removed it before... weird ;) ) * Acquire: grammar fixes + split schedule acquire test * Acquire: add release note * Acquire: release notes remove issues Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com>
This commit adds a new validation field type NumpyArray which is used to return a deserialized numpy array object. If a native numpy array object is passed in, that's returned verbatim and if it's a list it's first deserialized as the normal list field type and then cast as an array. This enables local simulators to return c aligned vectors or numpy arrays natively. However, for the online simulator case and for backwards compatibility the serialized list format needs to be honored. So if it's not a native numpy array object the previous method of deserializing a list is performed and that output list is cast as a numpy array. This new field type is then used in place of the previous List fields for the statevector and unitary result fields in the ExperimentResultDataSchema class so that local simulators can leverage this. As an example of how this can be used the BasicAer statevector and unitary simulators are also updated in this commit to return numpy arrays of complex numbers directly instead of the serialized list format it previously used. Fixes Qiskit#2731 Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
…ic pulse should be used in its place. This requires the user to know the duration for which the signal amplitude should be changed. (Qiskit#3756) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Add test Python files to MANIFEST.in * Add other test resources and tweaks Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Add an entry to the `MANIFEST.in` so the `LICENSE.txt` file is included in the .tar.gz source distribution.
* changed rep_time from microseconds to seconds. added one time warning for rep_time Fixes Qiskit#3598 * fixed docstring * changed so that rep_time only can be a float. now passes all unit tests * reverted all jsons, made rep_time conversion at `_parse_pulse_args()` in `assemble()` * Update assemble.py added 'rep_time' name to 'BackendDefault' named tuple * Update qiskit/compiler/assemble.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * added a test in test_backendconfiguration * linting and removed redundant arg in `assemble.py` * linting * more linting * removed rep_time from BackendDefault tuple * fixed parametric pulse error & lint * release note Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
* label over name * adjust tests * test_label_over_name_2286 * import * label when multibit
) * Add entropy and entanglement state measures * Add functions `entropy`, `mutual_information`, `concurrence`, and `entanglement_of_formation` to quantum_info.states that work with Statevector and DensityMatrix classes. * Add unittests for new functions * Deprecate the same named functions in tools.qi.py * Change default base of new von-Neuman entropy function from e to 2. * Allow entropy based functions to set custom base with kwarg * Deprecate everything in tools.qi.py and old state functions * Add release note
* move controlled gate class definitions into base gate module. * fix cyclic imports * update for new crx and cry * linting * linting * linting * minor * wrong import of U3Gate * module level pylint cyclic-import disable * update mapper ground truth * hack to get tox to work * solve bug associated with ToffoliGate import. * avoid multiple definitions * update warning category. * change stack level Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…e kwarg (Qiskit#3755) * all inplace kwarg to measure_all * fix style * fix lint * Update quantumcircuit.py * add inplace to other measure methods * add release note Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* First Commit * Add utility function * Remove redundant code * Add test * Move test to a new file * tweaks * remove unwanted imports * Remove ipdb * tweaking * Remove unwanted imports * Fix lint * Add tests * release notes * fix BaseBackend lint * fix docstrings and cyclic import lint * reno * Fix test * lint * add review suggestions * reno * Fix code * reno * Fix BaseBackend lint error * Update qiskit/pulse/utils.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/pulse/utils.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/pulse/utils.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/pulse/utils.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/pulse/utils.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * review suggestions * typo * Move measure to Scheduler utils * fix style * Update reno * Fix bug and add test * Review suggestions * Docstrings * Revert "Fix bug and add test" This reverts commit 7a2d677. * Fix bug and write test * fixes * Update qiskit/scheduler/methods/basic.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * reno * Fix review suggestions * Add test for format_meas_map function * Update test * lint * Separate tests and fix indentation * Fix lint * Fix review suggestions * Fix Error Message * reno * reno * Docstring * Docstring Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Our travis config file was using some deprecated syntax which is no longer supported on travis. This commit goes through and cleans things up to make sure the config is compliant with travis's syntax and enable running jobs again.
* instruction.op.num_ctrl_qubits * controlled_wires for knowing if controlled qubits sholud be at the edge * in, out, rest * OnWireMid with control_label * order in the paramenters * Qiskit#3546 test * lint * failing test * improve the connector * test control on top and bot * connectors to multibox, hackish * failing test * fix * lint * release notes
…iskit-terra into Cryoris-consistent_gate_naming
Cryoris
pushed a commit
that referenced
this pull request
Mar 25, 2020
add initial attempt at measurements
Cryoris
pushed a commit
that referenced
this pull request
May 27, 2020
…-HLF Added tests for HiddenLinearFunction
Cryoris
pushed a commit
that referenced
this pull request
Jul 11, 2020
* Fix setting contexts. * Make builder class private. * Add group transform. * Initial demo test is running (not necessarily doing the right thing. * Typed context gate call parameters. * Fix imports for builder. * Fix bugs in tests. * Minor changes. * Add pad context. Rename active -> current. * Add barrier test, expected fail. * Added group context test. * Fix bug in acquire instruction. * Add instruction tests. * Add builder utilities tests. * Fix bug in scheduler when no gates present in circuit. * Test transpiler and scheduler context settings / utilities. * Made children, a public method. * add default alignment context for builder. * Get tests working for call_schedule and call_circuit. Rework right align transform. * Rename test file. * Test measure macro. * Add delay_qubit macro test. * Update context builder test docstring. * Review suggestions * Add gate tests. Running into a bug with the schedule implementation. * Fix get_qubit_channels * Fix bug in acquire round 2. * Deprecation warning to use control(qubits: List) instead of control(channel: int) * Fix mutable insert flattening schedule tree. * Fix delay test using qubit index. * Fix using deprecated cnotgate. * typos * Rename alignment contexts. * update the control based on the new backend schema * typos * Unify alignment context naming. * Unify naming of transforms and fix broken align_right. * More logic fixes * lint * lint * add older code * More logic fixes * lint * Update docstrings and typehints * Unused imports * Release notes * Review suggestions * Bug fix for get_qubit_channels(0) Updated tests too * Review Suggestions * lint * Change error message of _get_channel_prefix_index * Added raise error for backends without 'channel' information * Update docstrings for raise errors * Fix error messages and docstrings * make self.channels private * Remove collections.Counter * Revert "Remove collections.Counter" This reverts commit d602738. * Add complex test. * Rename _schedule_lazy_circuit_before to _compile_lazy_circuit_before * Add delay_qubits instruction. Fix bug in schedule equality test. * Add frequency and phase offset contexts. * Renamed builder_context to builder. * Add inline directive. * linting. * Fix linting errors. * Add rescheduler linting. * Add transforms documentation. * Lint test builder. * Add macro linting. * Schedule linting. * lint pulse builder. * Remove cyclical imports with compiler import in pulse builder. * Add channel builder helper functions. Rename current to active. * Add relative barrier directive. * Refactor visualization namespacing. * Add barrier directive to builder. * Add num_qubits. * Add measure_all builder command. * Add acquire on qubit. * Add error if not all channels supplied to an Instruction is a channel. * Remove notebooks directory from hackathon. * linting * Fix issue with deprecated Delay. * Add backport packages for contextvars. * Reorder schedule and backend arguments. Make backend no longer required. * Small builder doc update. * Add simpler calling syntax for the builder. * Fix python versioninign. * Add __all__ for builder. * Add exceptions for no active builder or no backend set. * Update automodule Adds documentation of all non-private member function and properties * Remove unwanted docstrings Also fixes some typos * Fix pylint error - BackendNotSet not added in docstring * Fix weird bug * Fix 'commands' not imported * Fix typo * Rename pulse.reschedule -> pulse.transforms * Update surrounding code to support rename (releasenotes, add rescheduler back for import path deprecation, API documentation, update imports in tests) * Remove unwanted newlines * Reapply feedback from code review * Add test cases for issues with timeslots.' * Fix small bug in timeslot insertion finder. * Fixed another error in the code path. * Remove accidental comment. * Fix another small timeslot bug. (cherry picked from commit 28bbbdec13ebd137ca4e5fd1c61aff0c0304988e) * Fix small issue. * Moved circuit_scheduler back to scheduler. * Properly deprecate scheduler utils. * linting * Fix missed pieces when moving back scheduler. * Fix circular imports by using from instead of import * linting. * use Constant instead of ConstantPulse. * Rename pulse.reschedule -> pulse.transforms * Update surrounding code to support rename (releasenotes, add rescheduler back for import path deprecation, API documentation, update imports in tests) * Remove unwanted newlines * Reapply feedback from code review * Fix docs unexpected indent * Linting. * Change deprecation warning to emit warning at proper stack location. * Make changes to remove deprecation warnings. * Remove leftover files from moving of scheduler. * Revert ordering of channel and qubit arguments compared to parameters. * Add pulse builder documentation. * fix up builder tests. * Linting. * Docs update. * Fix deprecation warning. * Fix reno warnings * Some builder.py docstring updates * Documentation updates. * Fix issue with wrapped function not being properly documented. * Update builder docs to use jupyter-executer * Builder interface documentation. * Fix issue with pulse barrier padding. * Fix builder barrier doc. * Structure builder imports. * Update qiskit/pulse/instructions/directives.py Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/pulse/instructions/acquire.py Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/pulse/instructions/directives.py Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> * Fix call circuit. * Enable a samples_to_time and time_to_samples method. * Add test to builder for calling circuit with cregs. * Update qiskit/pulse/builder.py Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/pulse/builder.py Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/pulse/builder.py Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> * Revert acquire import changes. * Ignore trivial barriers. * Add note on future deprecation of calling gates within the pulse builder interface. * Remove commented out execution. * Update qiskit/pulse/transforms.py Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> * Remove mention of quantum circuit in builder documentation intro. * Update qiskit/pulse/builder.py Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> * Fix jupyter execute import style. * Fix unclear arguments in delay_qubits doc. * Make pulse builder warning more prominent and revise message. * Fixed import asthetic. * Move BackendNotSet to exceptions. * Fix more asthetic setting of default settings in builder. * Remove left over assert in builder. * Remove dead comment. * Reorder _call_circuit. * Fix small linting error * Fix commented out example code. * Remove comment headers. * Move NoActiveBuilder exception to exceptions. * Rename time to sample and vice versa to seconds to samples * Update macros module docstring. * Fix measure docstring spacing. * Update test_builder copyright. * Fix test docstrings. * Add notes for expected test failures. * Rename types sections to channels. * Fix test spacing. * Revert test modification. * Fix test_transform docstring. * Add better coverage for TestRemoveTrivialBarriers * Readd transform tests. * Change example usage to examples for uniformity. * linting invalid name. * Replace mutate flag with inplace to mirror the circuit model. * Allow passing name to pulse.build. * Fix bad builder example assert. * Allow frequency and phase offset contexts to broacast across channels. * Revert delay instruction error. * Remove unnecessary assignments for inplace schedule operations. * Reorder sequential transform reference ordering. * Removed unnecessary removal of barriers in transform test. * Verify that flattened works correctly by testing aligned on grouped schedule. * Make align right test depending on nesting. Refactor implementation of align_right. * Use append instead of append where it makes sense. Use inplace where I can. * Remove the pulse group instruction for now. * Added better inlining test. * Implement shift frequency and frequency_offset. * Clean up builder tests #1 * Deprecate warns only once. * Remove append_instruction from pulse namespace. * Fix bad test name in test_instructions. * Added beta flag. * Update flatten transform documentation. * Operator spaces. * Fix unnecessary else in schedule. * Fix operator spacing in test-transforms. * time to seconds * Fix misnamed test. * Revert children to _children. * Update pulse module docstring * linting. * Revert apidocs change in pulse. * Remove call_schedule, call_circuit, call_gate from top-level import. * Rename block to context_schedule. * Better error message. * Fix module level import. * revert reno files. * Added space in test builder. * Added set_phase instruction. * Revert visualization changes. * Remove unused import * Standardize imports for builder PR. * Docs updates. Co-authored-by: SooluThomas <soolu.elto@gmail.com> Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cryoris
pushed a commit
that referenced
this pull request
Jan 13, 2021
Transformation pass and code skeleton
Cryoris
pushed a commit
that referenced
this pull request
Mar 23, 2021
Fix imports for the ClassicalAdd
Cryoris
added a commit
that referenced
this pull request
Mar 1, 2022
Cryoris
added a commit
that referenced
this pull request
Mar 9, 2022
* rm deprecated algo methods * add reno * fix tests, remove from varalgo * intial point was said to be abstract in varalgo! * attempt to fix sphinx #1 of ? Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cryoris
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Feat: Add `get_causal_node` to `DAGCircuit`: - Also added `get_qubit_input_node` and `get_qubit_output_node`. * Test: Added tests to `dagcircuit.py` * Docs: Added release note * Chore: Remove type-checking in `dagcircuit.py` - Type checking was causing strange behavior during linting. * Added changes to speed up get_causal_cone (#1) - Replace lists with deque for the iteration. * Docs: Modify docstring and release note * Fix: Wrong comparison in `_get_input_output_node` * Remove: input and output node methods. * Lint: Fixed formatting * Docs: Fixed release-note * Docs: Fixed docstring and release note. * Fix: Output map double-lookup. * Docs: Fix inline comments. * Test: Added test for circuits with barriers * Refactor: rename to `quantum_causal_cone` * FIx: Use quantum_sucessors and docstring --------- Co-authored-by: danielleodigie <97267313+danielleodigie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments