Bug/sc 33809/an author can add other learning objects #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquinVill
requested review from
a team,
Greek,
pzalep1,
Cwagne17,
dsoto18,
stef359,
Romerico234 and
johngonz0
pzalep1
reviewed
Oct 7, 2024
src/app/onion/learning-object-builder/components/scaffold/add-child/add-child.component.ts
Outdated
Show resolved
Hide resolved
Cwagne17
requested changes
Oct 7, 2024
src/app/onion/learning-object-builder/components/scaffold/add-child/add-child.component.ts
Outdated
Show resolved
Hide resolved
johngonz0
approved these changes
Oct 9, 2024
pzalep1
reviewed
Oct 10, 2024
Comment on lines
+82
to
+84
| registerChange() { | ||
| this.needsChange$.next(); | ||
| } |
There was a problem hiding this comment.
Where is this called in the service?
There was a problem hiding this comment.
Only reference is in the add-evaluator.component.ts file. Should I move this to that file since its not used anywhere else?
There was a problem hiding this comment.
I would see who is subscribed to this and then make the call.
dsoto18
approved these changes
Oct 11, 2024
stef359
approved these changes
Oct 11, 2024
Cwagne17
approved these changes
Oct 14, 2024
pzalep1
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an author being able to add learning objects as children that are not owned by that author. This also fixes the search mechanism that was not returning any learning objects. I also consolidated the search.service.ts files into one file instead of 2.
Story: https://app.shortcut.com/clarkcan/story/33809/an-author-can-add-other-learning-objects-as-children
Video:
Screen.Recording.2024-10-09.at.2.24.35.PM.mov