Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/sc 33809/an author can add other learning objects #1876

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Bug/sc 33809/an author can add other learning objects #1876

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bb0af0
released learning object removal
Oct 4, 2024
438ab55
search fix :egg:
Oct 9, 2024
17a4efd
circleci fix:bug:
Oct 9, 2024
b4d0380
merge conflicts :egg:
Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/app/onion/learning-object-builder/components/scaffold/add-child/add-child.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,20 +62,8 @@ export class AddChildComponent implements OnInit, OnDestroy {
});
});

const releasedObjects = await this.searchLearningObjectService
.getLearningObjects({ ...filters, text: query, childId: this.child.id })
.then((response: { learningObjects: LearningObject[], total: number }) => {
let { learningObjects } = response;
const indx = this.lengths.indexOf(this.child.length);
const childrenLengths = this.lengths.slice(0, indx);
learningObjects = learningObjects.filter(
child => (!this.currentChildren.includes(child.id) && childrenLengths.includes(child.length))
);
return learningObjects;
});

joaquinVill marked this conversation as resolved.
Show resolved Hide resolved
this.loading = false;
return [...draftObjects, ...releasedObjects];
return draftObjects;
}
/**
* Takes the index of the LO within the array and emits it to the parent
Expand Down