Skip to content

Commit

Permalink
activate snapshooter_strict_mode (#286)
Browse files Browse the repository at this point in the history
CI/CD: Fix wrong snapshooter path.

Snapshooter was incorrectly searching for snapshots under /_/ on all operating systems. This was resolved on Linux and Windows by creating a symlink to /_/ or [Drive]:/_/. However, macOS does not permit this symlink, so I have decided to skip tests on macOS for now and prioritize other issues.

---

Signed-off-by: Michael Tsfoni <80639729+mtsfoni@users.noreply.github.com>
  • Loading branch information
mtsfoni authored May 19, 2024
1 parent 1e3886b commit a27d923
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion .github/workflows/dotnetcore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name: .NET Core CI

on: [pull_request, workflow_dispatch]

env:
SNAPSHOOTER_STRICT_MODE: true

jobs:
# Fail if there are build warnings
#
Expand Down Expand Up @@ -30,11 +33,21 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
# os: [ubuntu-latest, windows-latest, macos-latest]
# macos currently disabled. see issue #285 for more info.
os: [ubuntu-latest, windows-latest]
timeout-minutes: 30

steps:
- uses: actions/checkout@v3
- name: SnapshooterHotfixSymlinkLinux
if: matrix.os == 'ubuntu-latest'
run: sudo ln -s "$GITHUB_WORKSPACE" /_
shell: bash
- name: SnapshooterHotfixSymlinkWindows
if: matrix.os == 'windows-latest'
run: New-Item -ItemType SymbolicLink -Path "/_" -Target "$env:GITHUB_WORKSPACE"
shell: pwsh
- uses: actions/setup-dotnet@v3
with:
dotnet-version: '6.0.x'
Expand Down

0 comments on commit a27d923

Please sign in to comment.