Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activate snapshooter_strict_mode #286

Merged
merged 6 commits into from
May 19, 2024
Merged

activate snapshooter_strict_mode #286

merged 6 commits into from
May 19, 2024

Conversation

mtsfoni
Copy link
Contributor

@mtsfoni mtsfoni commented Apr 20, 2024

No description provided.

Signed-off-by: Michael Tsfoni <80639729+mtsfoni@users.noreply.github.com>
Signed-off-by: Michael Tsfoni <80639729+mtsfoni@users.noreply.github.com>
@andreas-hilti
Copy link
Contributor

@mtsfoni Can't you add something like original line 43:
if: matrix.os == 'ubuntu-latest'
Maybe it needs to be:
if: matrix.os == 'ubuntu-latest' || matrix.os == 'macos-latest'

.

Signed-off-by: Michael Tsfoni <80639729+mtsfoni@users.noreply.github.com>
Signed-off-by: Michael Tsfoni <80639729+mtsfoni@users.noreply.github.com>
Signed-off-by: Michael Tsfoni <80639729+mtsfoni@users.noreply.github.com>
@mtsfoni mtsfoni merged commit a27d923 into main May 19, 2024
9 of 10 checks passed
@mtsfoni
Copy link
Contributor Author

mtsfoni commented May 19, 2024

@andreas-hilti
Windows and Linux should be fixed, I deactivated MacOs for now. I don't see a lot of scenarios where tests of this library pass on Linux but fail on Mac anyway.

Could you rebase your PRs as I merged the fixes into main?

@andreas-hilti
Copy link
Contributor

@mtsfoni I rebased my latest 3 PRs. Let me know if I need to rebase also the older ones (which already ran successfully).

mtsfoni added a commit that referenced this pull request May 20, 2024
The combination of #246 (add testcase) and #286 (activate strict mode) caused this 'conflict'

Signed-off-by: MTsfoni <mibau89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants