Fix the xml serialization order #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properties needs to be in front of Components. Signed-off-by: andreas hilti <andreas.hilti@bluewin.ch>
jimklimov
approved these changes
Aug 21, 2023
|
|
||
| [XmlArray("properties")] | ||
| [XmlArrayItem("property")] | ||
| [ProtoMember(22)] | ||
| public List<Property> Properties { get; set; } | ||
| public bool ShouldSerializeProperties() { return Properties?.Count > 0; } | ||
|
|
||
| [XmlArray("components")] | ||
| [ProtoMember(21)] |
There was a problem hiding this comment.
Just in case: ProtoMember numbers should remain as they were, right? Or should match the order in other serializers?..
There was a problem hiding this comment.
Yes, they need to remain as they are; they are defined in
https://github.com/CycloneDX/specification/blob/c320fc0f0b46873864927d9d5684eea7ba439728/schema/bom-1.4.proto#L110-L113
(The order in the proto is different from the one in the xml.)
Signed-off-by: andreas hilti <andreas.hilti@bluewin.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties needs to be in front of Components in the xml format.
Compare https://cyclonedx.org/docs/1.4/xml/#type_component
This aims to address: CycloneDX/cyclonedx-cli#304