Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root components with empty name have a fallback #253

Merged
merged 1 commit into from
Feb 11, 2022
Merged

root components with empty name have a fallback #253

merged 1 commit into from
Feb 11, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Feb 11, 2022 •
edited
Loading

fix #252

  • implement fallback for component name
  • add test with components without a name

Q: should a unique id added to the fallback, so possible rendering does not result in duplicate unnamed components?
A: nope. no breaking changes intended.

Q: should the Component class have a name fallback? or should the causing bom.metadata.component be fixed instead?
A: nope. root component is the only thing that must be fixed right now.

@jkowalleck jkowalleck changed the title components with empty name have a fallback root components with empty name have a fallback Feb 11, 2022
@jkowalleck jkowalleck force-pushed the bugfix/issues-252 branch 6 times, most recently from 15ac9f2 to 06d5410 Compare February 11, 2022 12:25
jkowalleck
jkowalleck commented Feb 11, 2022
View reviewed changes
tests/__snapshots__/index.test.js.snap
],
\\"component\\": {
\\"type\\": \\"library\\",
\\"name\\": \\"NO-NAME-PACKAGE\\",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the expected filler name

@jkowalleck jkowalleck force-pushed the bugfix/issues-252 branch 2 times, most recently from 76bb7a7 to d09d707 Compare February 11, 2022 12:33
@jkowalleck jkowalleck mentioned this pull request Feb 11, 2022
Closed
@jkowalleck jkowalleck marked this pull request as ready for review February 11, 2022 15:24
@jkowalleck jkowalleck requested a review from a team as a code owner February 11, 2022 15:24
@jkowalleck
root component gets a fallback name
01148b1 
fix #252

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit c3fc0c7 into master Feb 11, 2022
@jkowalleck jkowalleck deleted the bugfix/issues-252 branch February 11, 2022 15:29
jkowalleck added a commit that referenced this pull request Feb 11, 2022
@jkowalleck
v3.4.1
bdc72d8 
* Fixed
  * root-packages without a name no longer cause unexpected crashes ([#252] via [#253])

[#252]: #252
[#253]: #253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.4.0 - ReferenceError: Name is required
1 participant
@jkowalleck