Skip to content

feat: add option to assign a UUID in BOM constructor #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: add option to assign a UUID in BOM constructor #316

wants to merge 1 commit into from

Conversation

@hakandilek
Copy link
Contributor

@hakandilek hakandilek commented Dec 13, 2022

Mainly the BOM receives a newly generated uuid assigned on the fly. This is basically a fix to enable passing an optional parameter within the constructor to be used as the uuid.

@hakandilek hakandilek requested a review from a team as a code owner December 13, 2022 21:15
@hakandilek
fix: option to assign a uuid for the BOM
c78a4f6 
Signed-off-by: Hakan Dilek <hakandilek@gmail.com>
jkowalleck
jkowalleck approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@jkowalleck jkowalleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkowalleck
Copy link
Member

jkowalleck commented Dec 13, 2022

@madpah can we move this in?

@hakandilek hakandilek mentioned this pull request Dec 13, 2022
Closed
@hakandilek
Copy link
Contributor Author

hakandilek commented Dec 14, 2022

Python 3.6 jobs are failing due to the missing support. Should I remove those here as well?

@jkowalleck
Copy link
Member

jkowalleck commented Dec 14, 2022

re: #316 (comment)

We are currently in a feature freeze state, in order to move forward
to https://github.com/CycloneDX/cyclonedx-python-lib/issues?q=is%3Aopen+is%3Aissue+milestone%3A4.0.0
via https://github.com/CycloneDX/cyclonedx-python-lib/tree/dev/3.0.0

This means that your PR might hang for a while.

@jkowalleck jkowalleck changed the title fix: option to assign a uuid for the BOM feat: add option to assign a UUID in BOM constructor Dec 14, 2022
@jkowalleck jkowalleck changed the title feat: add option to assign a UUID in BOM constructor feat: add option to assign a UUID in BOM constructor Dec 14, 2022
@jkowalleck jkowalleck added the enhancement New feature or request label Dec 14, 2022
@hakandilek
Copy link
Contributor Author

hakandilek commented Dec 14, 2022

https://github.com/CycloneDX/cyclonedx-python-lib/tree/dev/3.0.0

Should I cherry-pick the changes into dev/3.0.0 if it'll make things easier.

@jkowalleck
Copy link
Member

jkowalleck commented Dec 14, 2022

re: #316 (comment)
actually it would help to just close this very PullRequest and create a new one that introduces the desired behaviour into dev/3.0.0

@hakandilek
Copy link
Contributor Author

hakandilek commented Dec 16, 2022

I noticed that this constructor parameter is already present on dev/3.0.0, so closing this one,

@hakandilek hakandilek closed this Dec 16, 2022
@hakandilek hakandilek deleted the default-uuid branch December 16, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkowalleck jkowalleck jkowalleck approved these changes

Assignees

@madpah madpah

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hakandilek @jkowalleck @madpah