This repository was archived by the owner on Jun 20, 2019. It is now read-only.
Fix most failing tests that are marked 'unresolved'#164
Merged
ibuclaw merged 1 commit intoD-Programming-GDC:masterfrom Mar 7, 2016
Merged
Fix most failing tests that are marked 'unresolved'#164ibuclaw merged 1 commit intoD-Programming-GDC:masterfrom
ibuclaw merged 1 commit intoD-Programming-GDC:masterfrom
Conversation
ibuclaw
added a commit
that referenced
this pull request
Mar 7, 2016
Fix most failing tests that are marked 'unresolved'
Let's figure out the gcc version in the makefile, then we can handle both C++11 ABIs. |
Member
Author
|
I have been on and off considering how much hassle it would be to hook into g++'s cxx mangler and have some command line option to set ABI version (default being whatever g++ is) |
I think it's easy enough to select the ABI version on the D side and have different declarations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've add
--enable-language=c++,dto the semaphoreCI configure command, and set to buildlibstdc++-v3too.There should now only be two unresolved tests because of C++-11 ABI changes.
See: dlang/dmd#5262