Skip to content

Comments

[14965]: Add versioned-out branch to support new C++-11 implementations of std::string#5262

Merged
WalterBright merged 1 commit intodlang:masterfrom
ibuclaw:issue14956b
Nov 28, 2015
Merged

[14965]: Add versioned-out branch to support new C++-11 implementations of std::string#5262
WalterBright merged 1 commit intodlang:masterfrom
ibuclaw:issue14956b

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Nov 7, 2015

https://issues.dlang.org/show_bug.cgi?id=14956

Depends on #5261 - and would fix 14596, but we currently have no way to separate the two apart. Nor do I know whether it is worth the trouble.

@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 7, 2015

Nor do I know whether it is worth the trouble.

When I say this, I just question the usefulness of this test if it is known to fail depending on your environment or setup.

@WalterBright
Copy link
Member

I'll pull this for now. But in the future this will go into druntime, and I see no compelling reason to support any C++ compiler other than the latest g++ and clang++. Nor do we have the resources to do such support.

@WalterBright
Copy link
Member

Dang, I push the Merge button and nothing happens. This might have to wait until I get home. This is likely some issue with github and IE 11.

@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 9, 2015

support any C++ compiler other than the latest g++ and clang++.

I can see there being a disparity with our testsuite on this matter though. The latest C++ compiler on FreeBSD may not be the same latest on OSX or Linux.

Incidentally I've had this problem before with changes that break older debuggers but not the latest version (these PRs are still in limbo).

@WalterBright
Copy link
Member

Those can be versioned in the test suite using version(FreeBSD). I don't think we need to be terribly particular about the test suite code.

@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 9, 2015

That is at least true in this case.

@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 13, 2015

@WalterBright - did you forget to merge this?

@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 22, 2015

@WalterBright - weekly ping. ;-)

WalterBright added a commit that referenced this pull request Nov 28, 2015
[14965]: Add versioned-out branch to support new C++-11 implementations of std::string
@WalterBright WalterBright merged commit 574542f into dlang:master Nov 28, 2015
@ibuclaw ibuclaw deleted the issue14956b branch November 29, 2015 08:53
@MartinNowak
Copy link
Member

The makefile could find out the GCC version and toggle the test.
It's a bit annoying that it constantly fails on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants