Parameter types should have namespace std mangling too#5261
Merged
dnadlinger merged 1 commit intodlang:masterfrom Feb 13, 2016
Merged
Parameter types should have namespace std mangling too#5261dnadlinger merged 1 commit intodlang:masterfrom
dnadlinger merged 1 commit intodlang:masterfrom
Conversation
Member
|
LGTM, though a test is missing. |
Member
|
I agree, test case please! |
Member
Author
|
@WalterBright @MartinNowak - test added! I couldn't encapsulate it all together because of errors Is this error/limitation really necessary? |
Member
Author
|
@MartinNowak @WalterBright - ping for a response to my question? |
Member
Author
|
@MartinNowak @WalterBright - ping after two months. |
Member
|
So that's why the testsuite fails on my machine... It's pretty annoying, not being able to test locally. |
Member
Author
|
Rebased. @WalterBright @MartinNowak - review in your own time. ;-) |
Contributor
|
Auto-merge toggled on |
dnadlinger
added a commit
that referenced
this pull request
Feb 13, 2016
Parameter types should have namespace std mangling too
Member
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14956
Needed for proposed fix to work, otherwise the parameter type is mangled as
PN3std7__cxx11rather thanPNSt7__cxx11