#392: Make pylint errors cause a CI failure (#395)

* #392: set pylint ignores to false

* #392: fix pylint errors that now cause CI failure

* #392: fix more pylint errors

* #392: fix newline mistake

src/lbaf/Execution/lbsBruteForceAlgorithm.py

@@ -60,7 +60,7 @@ def compute_arrangement_works(self, objects: tuple, arrangement: tuple) -> dict:
             values["sent volume"] = v
 
             # Aggregate and store work for this rank
-            works[rank] = self.work_model.aggregate(values)
+            works[rank] = self._work_model.aggregate(values)
 
         # Return arrangement works
         return works
@@ -75,7 +75,7 @@ def execute(self, p_id: int, phases: list, distributions: dict, statistics: dict
         objects = []
 
         # Iterate over ranks
-        phase_ranks = phase.get_ranks()
+        phase_ranks = phases.get_ranks()
         for rank in phase_ranks:
             for o in rank.get_objects():
                 entry = {

src/lbaf/Execution/lbsRecursiveTransferStrategy.py

@@ -11,6 +11,7 @@
 from ..Model.lbsPhase import Phase
 from ..Utils.exception_handler import exc_handler
 from ..IO.lbsStatistics import inverse_transform_sample
+from ..Model.lbsObjectCommunicator import ObjectCommunicator
 
 class RecursiveTransferStrategy(TransferStrategyBase):
     """A concrete class for the recursive transfer strategy."""

tox.ini

@@ -51,8 +51,8 @@ allowlist_externals =
 alwayscopy = true
 download = true
 recreate  = true
-ignore_errors=true
-ignore_outcome=true
+ignore_errors=false
+ignore_outcome=false
 commands =
     bash -c 'mkdir -p artifacts; pylint --rcfile=.pylintrc --output-format=text,text:artifacts/pylint.txt src'