Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox: pylint fails in CI #392

Closed
pierrepebay opened this issue May 31, 2023 · 1 comment · Fixed by #395
Closed

tox: pylint fails in CI #392

pierrepebay opened this issue May 31, 2023 · 1 comment · Fixed by #395
Assignees
@pierrepebay @cwschilly

Comments

@pierrepebay
Copy link
Contributor

There is a Pylint: FAIL in the tox run in the CI, caused by 5 errors, as can be seen in these two pylint runs:
https://github.com/DARMA-tasking/LB-analysis-framework/actions/runs/5100999367/jobs/9169599480#step:7
lines 1200, 1201, 1215, 1217, 1389
https://github.com/DARMA-tasking/LB-analysis-framework/actions/runs/5100999367/jobs/9169599480#step:7
lines 1203, 1204, 1218, 1220, 1384
Although these do not (for now) produce actual python errors when using the applications, the pylint errors that are thrown show that they could potentially lead to some issues later on, so fixing them would be appropriate.
@pierrepebay
Copy link
Contributor Author

pierrepebay commented May 31, 2023 •
edited
Loading

tox.ini needs to have line 54 ignore_errors=true changed to ignore_errors=false so the pylint errors cause a CI failure. Some Pylint errors might need to be ignored in the .pylintrc with ignored-classes.

cwschilly added a commit that referenced this issue Jun 2, 2023
@cwschilly
#392: set pylint ignores to false
fd33dd4
@cwschilly cwschilly linked a pull request Jun 2, 2023 that will close this issue
#392: Make pylint errors cause a CI failure #395
Merged
@cwschilly cwschilly mentioned this issue Jun 2, 2023
Merged
cwschilly added a commit that referenced this issue Jun 2, 2023
@cwschilly
#392: fix pylint errors that now cause CI failure
e9897dc
cwschilly added a commit that referenced this issue Jun 2, 2023
@cwschilly
#392: fix more pylint errors
aeeaad0
cwschilly added a commit that referenced this issue Jun 2, 2023
@cwschilly
#392: fix newline mistake
739a624
cwschilly added a commit that referenced this issue Jun 5, 2023
@cwschilly
#392: Make pylint errors cause a CI failure (#395)
a476a26 
* #392: set pylint ignores to false

* #392: fix pylint errors that now cause CI failure

* #392: fix more pylint errors

* #392: fix newline mistake
@nmm0 nmm0 mentioned this issue Jun 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierrepebay pierrepebay

@cwschilly cwschilly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#392: Make pylint errors cause a CI failure DARMA-tasking/LB-analysis-framework
2 participants
@pierrepebay @cwschilly