Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Time and Load and add capabilities to handle Memory #279

Closed
ppebay opened this issue Aug 24, 2022 · 2 comments · Fixed by #280
Closed

Rename Time and Load and add capabilities to handle Memory #279

ppebay opened this issue Aug 24, 2022 · 2 comments · Fixed by #280
Assignees
Labels
enhancement New feature or request

Comments

@ppebay
Copy link
Contributor

ppebay commented Aug 24, 2022

This is related to the comments in vt PR 1888
@nmm0 @lifflander

@ppebay ppebay added the enhancement New feature or request label Aug 24, 2022
@ppebay ppebay self-assigned this Aug 24, 2022
@ppebay ppebay changed the title Rename Time and Load Rename Time and Load and add capabilities to handle Memory Aug 25, 2022
@ppebay
Copy link
Contributor Author

ppebay commented Aug 25, 2022

@marcinwrobel1986 Is the "user-defined" key handled by the JSON reader?

Thanks

@ppebay
Copy link
Contributor Author

ppebay commented Aug 28, 2022

Making sure visualizer in sync with new nomenclature:
Screen Shot 2022-08-29 at 12 45 50 AM
Screen Shot 2022-08-29 at 12 46 12 AM
Screen Shot 2022-08-29 at 12 46 19 AM

ppebay added a commit that referenced this issue Oct 23, 2022
ppebay added a commit that referenced this issue Oct 23, 2022
ppebay added a commit that referenced this issue Oct 31, 2022
ppebay added a commit that referenced this issue Nov 3, 2022
ppebay added a commit that referenced this issue Nov 3, 2022
ppebay pushed a commit that referenced this issue Nov 3, 2022
ppebay added a commit that referenced this issue Nov 9, 2022
ppebay added a commit that referenced this issue Nov 10, 2022
ppebay added a commit that referenced this issue Nov 17, 2022
ppebay pushed a commit that referenced this issue Nov 17, 2022
ppebay added a commit that referenced this issue Nov 17, 2022
ppebay added a commit that referenced this issue Nov 17, 2022
ppebay added a commit that referenced this issue Nov 18, 2022
* #279: Load in the case of ranks is now Rank Load

* Replace object Time with Load

* #279: completed refactoring of time -> load except for JSON files keys

* #281: - fixed wrong key

* #279: - defined context for multiprocessing.Pool

* #279: removed leftover  instances of get_time in rank object enumerator

* #279: ensure to not test with brute force

* #279: finalized per-object memory size additions

* #279: config file to test memory features with fake memory dataset

* #279: modified API to report stats of object loads (and use it)

* #279: fixed typo

* #279: - improve data stat file updater

* #279: modified reader for user-defined data regarding footprint

* #279: improved reading conventions

* #279: computing and reporting rank level memory

* #279: shared level memory

* #279: finalized implementation of maximum memory usage (rank stat)

* #279: renamed configuration file for user-defined-memory-exemplar case

* #279: new config file for memory toy problem

* #279: protected code against missing user-defined optional params

Co-authored-by: Marcin Wróbel <marcin.wrobel@ng-analytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant