Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"time" key must be replaced with "load" for objects in JSON files #281

Closed
ppebay opened this issue Aug 28, 2022 · 5 comments · Fixed by #293
Closed

"time" key must be replaced with "load" for objects in JSON files #281

ppebay opened this issue Aug 28, 2022 · 5 comments · Fixed by #293
Assignees
Labels
enhancement New feature or request

Comments

@ppebay
Copy link
Contributor

ppebay commented Aug 28, 2022

This must also be propagated to the validation harness

Related to #279

@ppebay ppebay added the enhancement New feature or request label Aug 28, 2022
@marcinwrobel1986
Copy link
Contributor

@ppebay I don't understand regarding which JSON files are you referring here.

Please confirm, that you have our output files in mind, like below:
Current output:

{
  "phases": [
    {
      "tasks": [
        {
          "time": 0.5,
          "resource": "cpu",
          "object": 2
        },
        {
          "time": 1.5,
          "resource": "cpu",
          "object": 8
        }
      ],
      "id": 2
    }
  ]
}

Desired output:

{
  "phases": [
    {
      "tasks": [
        {
          "load": 0.5,
          "resource": "cpu",
          "object": 2
        },
        {
          "load": 1.5,
          "resource": "cpu",
          "object": 8
        }
      ],
      "id": 2
    }
  ]
}

@marcinwrobel1986
Copy link
Contributor

@ppebay any answer here?

@ppebay
Copy link
Contributor Author

ppebay commented Oct 12, 2022

Yes your interpretation is correct. Thank you and sorry for the delay.

@ppebay
Copy link
Contributor Author

ppebay commented Oct 21, 2022

@marcinwrobel1986 quick status update?

@marcinwrobel1986
Copy link
Contributor

@marcinwrobel1986 quick status update?

@ppebay done here #293

ppebay added a commit that referenced this issue Oct 22, 2022
…ced-with-load-for-objects-in-JSON-files

#281: "time" key must be replaced with "load" for objects in JSON files
marcinwrobel1986 pushed a commit that referenced this issue Oct 23, 2022
ppebay pushed a commit that referenced this issue Nov 3, 2022
ppebay pushed a commit that referenced this issue Nov 17, 2022
ppebay added a commit that referenced this issue Nov 18, 2022
* #279: Load in the case of ranks is now Rank Load

* Replace object Time with Load

* #279: completed refactoring of time -> load except for JSON files keys

* #281: - fixed wrong key

* #279: - defined context for multiprocessing.Pool

* #279: removed leftover  instances of get_time in rank object enumerator

* #279: ensure to not test with brute force

* #279: finalized per-object memory size additions

* #279: config file to test memory features with fake memory dataset

* #279: modified API to report stats of object loads (and use it)

* #279: fixed typo

* #279: - improve data stat file updater

* #279: modified reader for user-defined data regarding footprint

* #279: improved reading conventions

* #279: computing and reporting rank level memory

* #279: shared level memory

* #279: finalized implementation of maximum memory usage (rank stat)

* #279: renamed configuration file for user-defined-memory-exemplar case

* #279: new config file for memory toy problem

* #279: protected code against missing user-defined optional params

Co-authored-by: Marcin Wróbel <marcin.wrobel@ng-analytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants