Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#123 Implement memory footprint mode #124

Merged
merged 16 commits into from
Sep 17, 2020
Merged

#123 Implement memory footprint mode #124

merged 16 commits into from
Sep 17, 2020

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Sep 2, 2020

fixes #123

@cz4rs
Copy link
Contributor Author

cz4rs commented Sep 3, 2020

note:
pushing some code here, but it's definitely still work-in-progress (requires improved naming (!) and docs, reduced code duplication, independence from serialize / separate operator, implementation for other containers etc.)

@cz4rs cz4rs force-pushed the 123-memory-footprint-mode branch 14 times, most recently from 8f35f3f to 63c2320 Compare September 8, 2020 15:35
@cz4rs cz4rs mentioned this pull request Sep 8, 2020
Merged
@cz4rs cz4rs force-pushed the 123-memory-footprint-mode branch 14 times, most recently from 7670e00 to a279ef5 Compare September 9, 2020 23:20
@cz4rs cz4rs force-pushed the 123-memory-footprint-mode branch from e49cab2 to fbd870c Compare September 15, 2020 17:38
@cz4rs cz4rs force-pushed the 123-memory-footprint-mode branch 2 times, most recently from 5c7a3ee to b73b4ea Compare September 15, 2020 23:45
cz4rs added 14 commits September 16, 2020 12:49
@cz4rs
#123 add README.md
69c8d40
@cz4rs
#123 implement memory footprint mode
f29cf0c 
Implement a function and a mode for measuring total memory footprint of
an object.

- use existing 'serialize' infrastructure
- add implementation and tests for std::unique_ptr, std::string, std::vector
@cz4rs
#123 implement memory footprinting for standard containers
72af815 
- adjust serialization code for Footprinting mode
- add unit tests for measuring memory footprint of standard containers
- fix compiler warning in traversal test
@cz4rs
#123 make CI tests output more verbose
4e9709b
@cz4rs
#123 implement memory footprinting for std::function
7ed71f7
@cz4rs
#123 implement memory footprinting for std::queue and std::priority_q…
c44808e 
…ueue
@cz4rs
#123 implement memory footprinting for std::chrono::duration
03a4516
@cz4rs
#123 implement memory footprinting for std::shared_ptr
3a066b3
@cz4rs
#123 implement memory footprinting for FILE
77e766a
@cz4rs
#123 compare calculated footprint with sizeof
290c11f
@cz4rs
#123 avoid double-counting footprint for std::array
fac01c9
@cz4rs
#123 prohibit use in other modes whe only Footprinting mode is supported
6462c2b
@cz4rs
#123 complete serialization support for std::chrono::duration
4ac5910
@cz4rs
#123 fix code review issues
5c16a23 
- do not size underlying 'struct FILE' when footprinting FILE* pointer
- simplify queue serialization to avoid copying
- fix grammar typo
@cz4rs cz4rs force-pushed the 123-memory-footprint-mode branch from b73b4ea to 5c16a23 Compare September 16, 2020 10:51
@cz4rs
Copy link
Contributor Author

cz4rs commented Sep 16, 2020

@PhilMiller @lifflander if this looks ok for you, I would like to get it merged to have better CI feedback in DARMA-tasking/vt#1013

(I would be adding support for kokkos types and ironing out any discovered bugs in a subsequent PR)

@cz4rs
Copy link
Contributor Author

cz4rs commented Sep 16, 2020

@lifflander @PhilMiller (thanks for the review!)
regarding the merge permissions / protected branches: please take a look at the screenshot below, I cannot merge this pull request myself

I don't have a fresh example from vt repository, but it looked pretty similar there (we discussed this some time ago on DARMA technical meeting)

image

@lifflander
Copy link
Contributor

lifflander commented Sep 17, 2020 •
edited
Loading

@lifflander @PhilMiller (thanks for the review!)
regarding the merge permissions / protected branches: please take a look at the screenshot below, I cannot merge this pull request myself

I believe that I have fixed this now for this repository.

@lifflander lifflander merged commit 7c8115e into develop Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@bradybray bradybray Awaiting requested review from bradybray

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

@pnstickne pnstickne Awaiting requested review from pnstickne

@lifflander lifflander Awaiting requested review from lifflander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement memory footprint mode
3 participants
@cz4rs @PhilMiller @lifflander