Skip to content

Commit

Permalink
#97: fix directory creation for python test
Browse files Browse the repository at this point in the history
  • Loading branch information
tlamonthezie committed Sep 5, 2024
1 parent 2365fdb commit 346e02d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .github/workflows/build-and-test-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,15 @@ jobs:
cd ${{ github.workspace }}
chmod +x ./ci/python_test.sh
# Create vizualization output directory (required).
sudo mkdir -p ${{ env.VT_TV_OUTPUT_DIR }}/python_tests
PYTHON_VERSIONS=(`echo '${{ join(matrix.host.python) }}' | sed 's/,/\n/g'`)
for python_version in "${PYTHON_VERSIONS[@]}"
do
# Clear vizualization output directory
rm -rf ${{ env.VT_TV_OUTPUT_DIR }}/python_tests/*
echo "::group::Test Python Bindings (${python_version})"
CONDA_PATH=${{ env.CONDA_PATH }} \
VT_TV_CONDA_ENV=py${python_version} \
Expand Down
2 changes: 2 additions & 0 deletions ci/docker/build-and-test-ubuntu.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ RUN VT_TV_COVERAGE_ENABLED=$VT_TV_COVERAGE_ENABLED bash /opt/src/vt-tv/ci/test.s

# Python tests (Builds VT-TV with Python bindings & test python package)
FROM test-cpp AS test-python
# Create vizualization output directory (required)
RUN mkdir -p /opt/src/vt-tv/output/python_tests
RUN bash /opt/src/vt-tv/ci/python_build.sh
RUN VT_TV_PYTHON_TESTS_OUTPUT_DIR=/opt/src/vt-tv/output/python_tests bash /opt/src/vt-tv/ci/python_test.sh

Expand Down
1 change: 0 additions & 1 deletion ci/python_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ if [[ $(uname -a) != *"Darwin"* ]]; then
fi

# Run test
mkdir -p $VT_TV_PYTHON_TESTS_OUTPUT_DIR
python $VT_TV_SRC_DIR/tests/test_bindings.py

# Restore display
Expand Down

0 comments on commit 346e02d

Please sign in to comment.