Merge pull request #2360 from DARMA-tasking/2286-remove-gcc-8-support

#2286: Remove `gcc-8` support
DARMA-tasking · Dec 5, 2024 · 2fd8152 · 2fd8152
2 parents 66786a6 + b492585
commit 2fd8152
Show file tree

Hide file tree

Showing 27 changed files with 96 additions and 503 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -25,7 +25,7 @@ If applicable, add screenshots to help explain your problem.
 
 **Platform (please complete the following information):**
  - Supercomputer or desktop [e.g., Trinity, Sierra)
- - Compiler environment [e.g., clang-4.0, gcc8]
+ - Compiler environment [e.g., clang-4.0, gcc9]
  - Libraries [e.g., mpich-2, openmpi)
  - Commit ID or release of VT [e.g., vt-1.0.0]
 

diff --git a/README.md b/README.md
@@ -4,11 +4,11 @@
 [![codecov](https://codecov.io/gh/DARMA-tasking/vt/branch/develop/graph/badge.svg)](https://codecov.io/gh/DARMA-tasking/vt)
 [![License](https://img.shields.io/badge/License-BSD%203--Clause-orange.svg)](https://opensource.org/licenses/BSD-3-Clause)
 ![](https://github.com/DARMA-tasking/vt/workflows/Docker%20Image%20CI/badge.svg)
-[![gcc-8, ubuntu, mpich, address sanitizer](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-8%2C%20ubuntu%2C%20mpich%2C%20address%20sanitizer)?branchName=develop&Label=(gcc-8%2C%20ubuntu%2C%20mpich%2C%20address%20sanitizer))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=9&branchName=develop)
 [![gcc-9, ubuntu, mpich, zoltan](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-9%2C%20ubuntu%2C%20mpich%2C%20zoltan)?branchName=develop&Label=(gcc-9%2C%20ubuntu%2C%20mpich%2C%20zoltan))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=10&branchName=develop)
 [![gcc-10, ubuntu, openmpi, no LB](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-10%2C%20ubuntu%2C%20openmpi%2C%20no%20LB)?branchName=develop&Label=(gcc-10%2C%20ubuntu%2C%20openmpi%2C%20no%20LB))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=4&branchName=develop)
 [![gcc-11, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-11%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(gcc-11%2C%20ubuntu%2C%20mpich%2C%20trace%20runtime%2C%20coverage))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=29&branchName=develop)
 [![gcc-12, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-12%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(gcc-12%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=30&branchName=develop)
+[![gcc-13, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-13%2C%20ubuntu%2C%20mpich%2C%20address%20sanitizer)?branchName=develop&Label=(gcc-13%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=36&branchName=develop)
 [![clang-9, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(clang-9%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(clang-9.0%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build?definitionId=22&branchName=develop)
 [![clang-10, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(clang-10%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(clang-10.0%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build?definitionId=21&branchName=develop)
 [![clang-11, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(clang-11%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(clang-11.0%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build?definitionId=25&branchName=develop)

diff --git a/ci/azure/azure-clang-16-ubuntu-mpich.yml b/ci/azure/azure-clang-16-ubuntu-mpich.yml
@@ -2,7 +2,7 @@
 ############## Warning this is a generated file---do not modify ###############
 ###############################################################################
 
-name: PR tests (clang-16, ubuntu, mpich)
+name: PR tests (clang-16, ubuntu, mpich, json schema test)
 
 trigger:
   branches:
@@ -58,7 +58,7 @@ variables:
   VT_KOKKOS_ENABLED: 0
   VT_TV_ENABLED: 0
   CMAKE_CXX_STANDARD: 17
-  VT_CI_TEST_LB_SCHEMA: 0
+  VT_CI_TEST_LB_SCHEMA: 1
   RUN_FULL_CI: true
   CACHE: "$(Agent.TempDirectory)/cache/"
   cache_name: ubuntu-clang-16-cache

diff --git a/ci/azure/azure-gcc-8-ubuntu-mpich.yml → ci/azure/azure-gcc-13-ubuntu-mpich.yml b/ci/azure/azure-gcc-8-ubuntu-mpich.yml → ci/azure/azure-gcc-13-ubuntu-mpich.yml
@@ -2,7 +2,7 @@
 ############## Warning this is a generated file---do not modify ###############
 ###############################################################################
 
-name: PR tests (gcc-8, ubuntu, mpich, address sanitizer)
+name: PR tests (gcc-13, ubuntu, mpich, address sanitizer)
 
 trigger:
   branches:
@@ -25,10 +25,10 @@ variables:
   tag: '$(Build.BuildId)'
   REPO: lifflander1/vt
   ARCH: amd64
-  UBUNTU: 18.04
+  UBUNTU: 24.04
   COMPILER_TYPE: gnu
-  COMPILER: gcc-8
-  HOST_COMPILER: gcc-8
+  COMPILER: gcc-13
+  HOST_COMPILER: gcc-13
   BUILD_TYPE: release
   ULIMIT_CORE: 0
   VT_CODE_COVERAGE: 0
@@ -61,7 +61,7 @@ variables:
   VT_CI_TEST_LB_SCHEMA: 0
   RUN_FULL_CI: true
   CACHE: "$(Agent.TempDirectory)/cache/"
-  cache_name: ubuntu-gcc-8-cache
+  cache_name: ubuntu-gcc-13-cache
   volume_name: ubuntu-cpp
   build_root: "$(CACHE)$(ARCH)-ubuntu-$(UBUNTU)-$(HOST_COMPILER)-$(COMPILER)-cache/"
   TS: 0

diff --git a/ci/azure/azure-gcc-9-ubuntu-mpich.yml b/ci/azure/azure-gcc-9-ubuntu-mpich.yml
@@ -2,7 +2,7 @@
 ############## Warning this is a generated file---do not modify ###############
 ###############################################################################
 
-name: PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)
+name: PR tests (gcc-9, ubuntu, mpich, zoltan)
 
 trigger:
   branches:
@@ -58,7 +58,7 @@ variables:
   VT_KOKKOS_ENABLED: 0
   VT_TV_ENABLED: 0
   CMAKE_CXX_STANDARD: 17
-  VT_CI_TEST_LB_SCHEMA: 1
+  VT_CI_TEST_LB_SCHEMA: 0
   RUN_FULL_CI: true
   CACHE: "$(Agent.TempDirectory)/cache/"
   cache_name: ubuntu-gcc-9-cache

diff --git a/ci/docker/alpine-cpp.dockerfile b/ci/docker/alpine-cpp.dockerfile
@@ -52,43 +52,6 @@ ENV CC=mpicc \
 
 FROM base as build
 COPY . /vt
-
-ARG VT_LB_ENABLED
-ARG VT_TRACE_ENABLED
-ARG VT_TRACE_RUNTIME_ENABLED
-ARG VT_MIMALLOC_ENABLED
-ARG VT_DOXYGEN_ENABLED
-ARG VT_ASAN_ENABLED
-ARG VT_UBSAN_ENABLED
-ARG VT_WERROR_ENABLED
-ARG VT_POOL_ENABLED
-ARG VT_PRODUCTION_BUILD_ENABLED
-ARG VT_FCONTEXT_ENABLED
-ARG CMAKE_BUILD_TYPE
-ARG VT_NO_COLOR_ENABLED
-ARG BUILD_SHARED_LIBS
-ARG CMAKE_CXX_STANDARD
-ARG VT_DEBUG_VERBOSE
-ARG VT_CI_BUILD
-
-ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
-    VT_TRACE_ENABLED=${VT_TRACE_ENABLED} \
-    VT_MIMALLOC_ENABLED=${VT_MIMALLOC_ENABLED} \
-    VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
-    VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
-    VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
-    VT_UBSAN_ENABLED=${VT_UBSAN_ENABLED} \
-    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
-    VT_POOL_ENABLED=${VT_POOL_ENABLED} \
-    VT_PRODUCTION_BUILD_ENABLED=${VT_PRODUCTION_BUILD_ENABLED} \
-    VT_FCONTEXT_ENABLED=${VT_FCONTEXT_ENABLED} \
-    VT_NO_COLOR_ENABLED=${VT_NO_COLOR_ENABLED} \
-    CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} \
-    BUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} \
-    CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
-    VT_DEBUG_VERBOSE=${VT_DEBUG_VERBOSE} \
-    VT_CI_BUILD=${VT_CI_BUILD}
-
 RUN /vt/ci/build_cpp.sh /vt /build
 
 FROM build as test

diff --git a/ci/docker/develop.dockerfile b/ci/docker/develop.dockerfile
@@ -31,50 +31,6 @@ RUN if test ${zoltan_enabled} -eq 1; then \
 
 COPY . /vt
 
-ARG VT_LB_ENABLED
-ARG VT_TRACE_ENABLED
-ARG VT_TRACE_RUNTIME_ENABLED
-ARG VT_MIMALLOC_ENABLED
-ARG VT_DOXYGEN_ENABLED
-ARG VT_ASAN_ENABLED
-ARG VT_UBSAN_ENABLED
-ARG VT_WERROR_ENABLED
-ARG VT_POOL_ENABLED
-ARG VT_PRODUCTION_BUILD_ENABLED
-ARG VT_ZOLTAN_ENABLED
-ARG CMAKE_BUILD_TYPE
-ARG VT_EXTENDED_TESTS_ENABLED
-ARG VT_FCONTEXT_ENABLED
-ARG VT_NO_COLOR_ENABLED
-ARG BUILD_SHARED_LIBS
-ARG CMAKE_CXX_STANDARD
-ARG VT_DEBUG_VERBOSE
-ARG VT_CI_BUILD
-
-ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
-    VT_TRACE_ENABLED=${VT_TRACE_ENABLED} \
-    VT_MIMALLOC_ENABLED=${VT_MIMALLOC_ENABLED} \
-    VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
-    VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
-    VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
-    VT_UBSAN_ENABLED=${VT_UBSAN_ENABLED} \
-    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
-    VT_POOL_ENABLED=${VT_POOL_ENABLED} \
-    VT_PRODUCTION_BUILD_ENABLED=${VT_PRODUCTION_BUILD_ENABLED} \
-    VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
-    VT_ZOLTAN_ENABLED=${VT_ZOLTAN_ENABLED} \
-    VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \
-    VT_UNITY_BUILD_ENABLED=${VT_UNITY_BUILD_ENABLED} \
-    VT_FCONTEXT_ENABLED=${VT_FCONTEXT_ENABLED} \
-    VT_DIAGNOSTICS_ENABLED=${VT_DIAGNOSTICS_ENABLED} \
-    VT_DIAGNOSTICS_RUNTIME_ENABLED=${VT_DIAGNOSTICS_RUNTIME_ENABLED} \
-    VT_NO_COLOR_ENABLED=${VT_NO_COLOR_ENABLED} \
-    CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} \
-    BUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} \
-    CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
-    VT_DEBUG_VERBOSE=${VT_DEBUG_VERBOSE} \
-    VT_CI_BUILD=${VT_CI_BUILD}
-
 RUN /vt/ci/build_cpp.sh /vt /build
 RUN /vt/ci/test_cpp.sh /vt /build
 RUN /vt/ci/build_vt_sample.sh /vt /build
diff --git a/ci/docker/ubuntu-20.04-gnu-openmpi-cpp.dockerfile b/ci/docker/ubuntu-20.04-gnu-openmpi-cpp.dockerfile
@@ -78,51 +78,6 @@ ENV OMPI_ALLOW_RUN_AS_ROOT=1 \
 
 FROM base as build
 COPY . /vt
-
-ARG VT_LB_ENABLED
-ARG VT_TRACE_ENABLED
-ARG VT_TRACE_RUNTIME_ENABLED
-ARG VT_MIMALLOC_ENABLED
-ARG VT_DOXYGEN_ENABLED
-ARG VT_ASAN_ENABLED
-ARG VT_UBSAN_ENABLED
-ARG VT_WERROR_ENABLED
-ARG VT_POOL_ENABLED
-ARG VT_PRODUCTION_BUILD_ENABLED
-ARG VT_ZOLTAN_ENABLED
-ARG VT_FCONTEXT_ENABLED
-ARG CMAKE_BUILD_TYPE
-ARG VT_EXTENDED_TESTS_ENABLED
-ARG VT_NO_COLOR_ENABLED
-ARG BUILD_SHARED_LIBS
-ARG CMAKE_CXX_STANDARD
-ARG VT_DEBUG_VERBOSE
-ARG VT_CI_BUILD
-
-ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
-    VT_TRACE_ENABLED=${VT_TRACE_ENABLED} \
-    VT_MIMALLOC_ENABLED=${VT_MIMALLOC_ENABLED} \
-    VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
-    VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
-    VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
-    VT_UBSAN_ENABLED=${VT_UBSAN_ENABLED} \
-    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
-    VT_POOL_ENABLED=${VT_POOL_ENABLED} \
-    VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
-    VT_ZOLTAN_ENABLED=${VT_ZOLTAN_ENABLED} \
-    VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \
-    VT_UNITY_BUILD_ENABLED=${VT_UNITY_BUILD_ENABLED} \
-    VT_PRODUCTION_BUILD_ENABLED=${VT_PRODUCTION_BUILD_ENABLED} \
-    VT_FCONTEXT_ENABLED=${VT_FCONTEXT_ENABLED} \
-    VT_DIAGNOSTICS_ENABLED=${VT_DIAGNOSTICS_ENABLED} \
-    VT_DIAGNOSTICS_RUNTIME_ENABLED=${VT_DIAGNOSTICS_RUNTIME_ENABLED} \
-    VT_NO_COLOR_ENABLED=${VT_NO_COLOR_ENABLED} \
-    CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} \
-    BUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} \
-    CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
-    VT_DEBUG_VERBOSE=${VT_DEBUG_VERBOSE} \
-    VT_CI_BUILD=${VT_CI_BUILD}
-
 RUN /vt/ci/build_cpp.sh /vt /build
 
 FROM build as test

diff --git a/ci/docker/ubuntu-clang-cpp.dockerfile b/ci/docker/ubuntu-clang-cpp.dockerfile
@@ -1,6 +1,6 @@
 ARG arch=amd64
 ARG ubuntu=20.04
-FROM ${arch}/ubuntu:${ubuntu} as base
+FROM ${arch}/ubuntu:${ubuntu} AS base
 
 ARG proxy=""
 ARG compiler=clang-11
@@ -14,22 +14,27 @@ ENV DEBIAN_FRONTEND=noninteractive
 
 RUN apt-get update -y -q && \
     apt-get install -y -q --no-install-recommends \
-    ${compiler} \
-    ${ubsan_enabled:+llvm-$(echo ${compiler} | cut -d- -f2)} \
-    ca-certificates \
-    ccache \
-    curl \
-    git \
-    less \
-    libomp-dev \
-    libomp5 \
-    make-guile \
-    ninja-build \
-    python3 \
-    valgrind \
-    wget \
-    zlib1g \
-    zlib1g-dev && \
+        ${compiler} \
+        ${ubsan_enabled:+llvm-$(echo ${compiler} | cut -d- -f2)} \
+        brotli \
+        ca-certificates \
+        ccache \
+        curl \
+        git \
+        less \
+        libomp-dev \
+        libomp5 \
+        make-guile \
+        ninja-build \
+        python3 \
+        python3-brotli \
+        python3-deepdiff \
+        python3-pip \
+        python3-schema \
+        valgrind \
+        wget \
+        zlib1g \
+        zlib1g-dev && \
     apt-get clean && \
     rm -rf /var/lib/apt/lists/*
 
@@ -52,10 +57,7 @@ ENV PATH=/cmake/bin/:$PATH
 ENV LESSCHARSET=utf-8
 
 COPY ./ci/deps/mpich.sh mpich.sh
-RUN if [ "$ubuntu" = "18.04" ]; then \
-      ./mpich.sh 3.3.2 -j4; else \
-      ./mpich.sh 4.0.2 -j4; \
-    fi
+RUN ./mpich.sh 4.0.2 -j4
 
 ENV MPI_EXTRA_FLAGS="" \
     CMAKE_PREFIX_PATH="/lib/x86_64-linux-gnu/" \
@@ -64,52 +66,9 @@ ENV MPI_EXTRA_FLAGS="" \
 
 FROM base as build
 COPY . /vt
-
-ARG BUILD_SHARED_LIBS
-ARG CMAKE_BUILD_TYPE
-ARG VT_ASAN_ENABLED
-ARG VT_DOXYGEN_ENABLED
-ARG VT_EXTENDED_TESTS_ENABLED
-ARG VT_FCONTEXT_ENABLED
-ARG VT_LB_ENABLED
-ARG VT_MIMALLOC_ENABLED
-ARG VT_NO_COLOR_ENABLED
-ARG VT_POOL_ENABLED
-ARG VT_PRODUCTION_BUILD_ENABLED
-ARG VT_TRACE_ENABLED
-ARG VT_TRACE_RUNTIME_ENABLED
-ARG VT_UBSAN_ENABLED
-ARG VT_WERROR_ENABLED
-ARG CMAKE_CXX_STANDARD
-ARG VT_DEBUG_VERBOSE
-ARG VT_CI_BUILD
-
-ENV BUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} \
-    CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
-    VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
-    VT_DIAGNOSTICS_ENABLED=${VT_DIAGNOSTICS_ENABLED} \
-    VT_DIAGNOSTICS_RUNTIME_ENABLED=${VT_DIAGNOSTICS_RUNTIME_ENABLED} \
-    VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
-    VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \
-    VT_FCONTEXT_ENABLED=${VT_FCONTEXT_ENABLED} \
-    VT_LB_ENABLED=${VT_LB_ENABLED} \
-    VT_MIMALLOC_ENABLED=${VT_MIMALLOC_ENABLED} \
-    VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
-    VT_NO_COLOR_ENABLED=${VT_NO_COLOR_ENABLED} \
-    VT_POOL_ENABLED=${VT_POOL_ENABLED} \
-    VT_PRODUCTION_BUILD_ENABLED=${VT_PRODUCTION_BUILD_ENABLED} \
-    VT_TRACE_ENABLED=${VT_TRACE_ENABLED} \
-    VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
-    VT_UBSAN_ENABLED=${VT_UBSAN_ENABLED} \
-    VT_UNITY_BUILD_ENABLED=${VT_UNITY_BUILD_ENABLED} \
-    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
-    CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} \
-    VT_DEBUG_VERBOSE=${VT_DEBUG_VERBOSE} \
-    VT_CI_BUILD=${VT_CI_BUILD}
-
 RUN /vt/ci/build_cpp.sh /vt /build
 
-FROM build as test
+FROM build AS test
 RUN /vt/ci/test_cpp.sh /vt /build
 
 RUN /vt/ci/build_vt_sample.sh /vt /build