Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for gcc-8 #2286

Closed
cz4rs opened this issue May 17, 2024 · 0 comments · Fixed by #2360
Closed

Remove support for gcc-8 #2286

cz4rs opened this issue May 17, 2024 · 0 comments · Fixed by #2360
Assignees
@thearusable
Labels
type: task

Comments

@cz4rs
Copy link
Contributor

cz4rs commented May 17, 2024

What Needs to be Done?
#2282 utilizes [[maybe_unused]] to silence a bunch of warnings, but support for that attribute is incomplete in gcc-8 (see Slack discussion).

Remove support for gcc-8 and bump compiler requirement to gcc-9 for vt:

  • remove gcc-8 build from CI
  • update documentation and wiki
  • remove workarounds from b832ffc
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Remove gcc-8 references
434de5d
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Remove std::filesystem workaround for gcc-8
d8b9cd9
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Replace old gcc-8 address sanitizer CI with gcc-13
56855f0
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Temporary enable new gcc-13 CI
7ce394a
@thearusable thearusable mentioned this issue Sep 30, 2024
Merged
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Remove workaround in code for gcc-8
9e6faab
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Remove warnings during perf tests compilation
9bd67d1
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Temporary force gcc-13 pipeline to run
47527d3
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Update ubuntu version for new CI to 24.04
f09015f
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Remove workaround in code for gcc-8
3304ff7
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Remove warnings during perf tests compilation
ae2268c
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: Update ubuntu version for new CI to 24.04
5841254
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#2286: temporary enable all CIs
a076496
cz4rs pushed a commit that referenced this issue Nov 14, 2024
@thearusable @cz4rs
#2286: Remove gcc-8 references
97a9a03
cz4rs pushed a commit that referenced this issue Nov 14, 2024
@thearusable @cz4rs
#2286: Remove std::filesystem workaround for gcc-8
21c1e64
cz4rs pushed a commit that referenced this issue Nov 14, 2024
@thearusable @cz4rs
#2286: Replace old gcc-8 address sanitizer CI with gcc-13
bc1f86a
cz4rs pushed a commit that referenced this issue Nov 14, 2024
@thearusable @cz4rs
#2286: Remove workaround in code for gcc-8
c5a66f7
cz4rs pushed a commit that referenced this issue Nov 14, 2024
@thearusable @cz4rs
#2286: Remove warnings during perf tests compilation
bb22804
cz4rs pushed a commit that referenced this issue Nov 14, 2024
@thearusable @cz4rs
#2286: Update ubuntu version for new CI to 24.04
2b6a555
cz4rs added a commit that referenced this issue Nov 15, 2024
@cz4rs
#2286: do not use cache when building docker images
f2bcaea
cz4rs pushed a commit that referenced this issue Nov 22, 2024
@thearusable @cz4rs
#2286: Remove gcc-8 references
4723d88
cz4rs pushed a commit that referenced this issue Nov 22, 2024
@thearusable @cz4rs
#2286: Remove std::filesystem workaround for gcc-8
4a493bd
cz4rs pushed a commit that referenced this issue Nov 22, 2024
@thearusable @cz4rs
#2286: Replace old gcc-8 address sanitizer CI with gcc-13
ac79d83
cz4rs pushed a commit that referenced this issue Nov 22, 2024
@thearusable @cz4rs
#2286: Remove workaround in code for gcc-8
3389b78
cz4rs pushed a commit that referenced this issue Nov 22, 2024
@thearusable @cz4rs
#2286: Remove warnings during perf tests compilation
fe764e0
cz4rs pushed a commit that referenced this issue Nov 22, 2024
@thearusable @cz4rs
#2286: Update ubuntu version for new CI to 24.04
82c439f
lifflander added a commit that referenced this issue Dec 5, 2024
@lifflander
Merge pull request #2360 from DARMA-tasking/2286-remove-gcc-8-support
2fd8152 
#2286: Remove `gcc-8` support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thearusable thearusable

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2286: Remove gcc-8 support DARMA-tasking/vt
2 participants
@cz4rs @thearusable