#2299: Replace double with std::chrono

DARMA-tasking · Aug 28, 2024 · e987173 · e987173
1 parent 0bf1dad
commit e987173
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/src/vt/vrt/collection/balance/baselb/baselb.h b/src/vt/vrt/collection/balance/baselb/baselb.h
@@ -55,6 +55,7 @@
 #include <map>
 #include <unordered_map>
 #include <tuple>
+#include <chrono>
 
 namespace vt { namespace vrt { namespace collection {
 
@@ -193,9 +194,8 @@ struct BaseLB {
    *
    * \return the estimated time
    */
-  double getCollectiveEpochCost() const {
-    // 100 ns
-    return 0.0000001;
+  auto getCollectiveEpochCost() const {
+    return std::chrono::nanoseconds(100);
   }
 
 private:

diff --git a/src/vt/vrt/collection/balance/greedylb/greedylb.cc b/src/vt/vrt/collection/balance/greedylb/greedylb.cc
@@ -161,7 +161,10 @@ void GreedyLB::loadStats() {
   this_load_begin = this_load;
 
   // Use an estimated load-balancing cost on average rank load to load-balance
-  if (avg_load > getCollectiveEpochCost()) {
+  auto avg_ns = std::chrono::duration_cast<std::chrono::nanoseconds>(
+    std::chrono::duration<double>(avg_load)
+  );
+  if (avg_ns > getCollectiveEpochCost()) {
     should_lb = I > greedy_tolerance;
   }
 

diff --git a/src/vt/vrt/collection/balance/hierarchicallb/hierlb.cc b/src/vt/vrt/collection/balance/hierarchicallb/hierlb.cc
@@ -264,7 +264,10 @@ void HierarchicalLB::loadStats() {
   this_load_begin = this_load;
 
   // Use an estimated load-balancing cost on average rank load to load-balance
-  if (avg_load > getCollectiveEpochCost()) {
+  auto avg_ns = std::chrono::duration_cast<std::chrono::nanoseconds>(
+    std::chrono::duration<double>(avg_load)
+  );
+  if (avg_ns > getCollectiveEpochCost()) {
     should_lb = I > hierlb_tolerance;
   }
 

diff --git a/src/vt/vrt/collection/balance/temperedlb/temperedlb.cc b/src/vt/vrt/collection/balance/temperedlb/temperedlb.cc
@@ -450,7 +450,10 @@ void TemperedLB::runLB(LoadType total_load) {
   }
 
   // Use an estimated load-balancing cost on average rank load to load-balance
-  if (avg > getCollectiveEpochCost()) {
+  auto avg_ns = std::chrono::duration_cast<std::chrono::nanoseconds>(
+    std::chrono::duration<double>(avg)
+  );
+  if (avg_ns > getCollectiveEpochCost()) {
     should_lb = max > (run_temperedlb_tolerance + 1.0) * target_max_load_;
   }