Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid trace timings #2147

Closed
nmm0 opened this issue May 11, 2023 · 0 comments · Fixed by #2148
Closed

invalid trace timings #2147

nmm0 opened this issue May 11, 2023 · 0 comments · Fixed by #2148
Labels
type: bug

Comments

@nmm0
Copy link
Collaborator

nmm0 commented May 11, 2023

Describe the bug
Projections will complain about corrupted or invalid trace files, or that the time of a handler cannot fit into an integer. Occasionally, I see large negative numbers in the latency of a handler in the trace.

This makes me think that there may be some uninitialized values in the trace.

This bug seems to be introduced by #1998 as I have bisected and versions of VT from before that was merged work correctly.
@nmm0 nmm0 added the type: bug label May 11, 2023
@nmm0 nmm0 changed the title potentially uninitialized trace timings invalid trace timings May 15, 2023
nmm0 added a commit that referenced this issue May 15, 2023
@nmm0
#2147: fix incorrect order of parameters for call to beginProcessing
382d6f3
This was referenced May 15, 2023
Merged
Closed
Open
@stmcgovern stmcgovern assigned stmcgovern and unassigned stmcgovern May 16, 2023
nmm0 added a commit that referenced this issue May 16, 2023
@nmm0
#2147: make getTracesSize() noexcept
a1e50b5
nmm0 added a commit that referenced this issue May 16, 2023
@nmm0
#2147: add functions for getting the number of trace events and the l…
20e5a2b 
…ast trace event
nmm0 added a commit that referenced this issue May 16, 2023
@nmm0
#2147: if adding a memory event to begin/endProcessing, use the same …
89f7958 
…time as the processing event
nmm0 added a commit that referenced this issue May 16, 2023
@nmm0
#2147: cmake: add functionality to add --vt_trace to trace tests in c…
9f1747c 
…test
nmm0 added a commit that referenced this issue May 16, 2023
@nmm0
#2147: cmake: add test to ensure timings are recorded correctly for c…
c46f216 
…alls to start() and finish() trace runnable components
nmm0 added a commit that referenced this issue May 16, 2023
@nmm0
#2147: fix test file license
8835f53
nmm0 added a commit that referenced this issue May 16, 2023
@nmm0
#2147: add documentation for added Trace functions
f164f59
nmm0 added a commit that referenced this issue May 18, 2023
@nmm0
#2147: fix incorrect order of parameters for call to beginProcessing
29ec80b
nmm0 added a commit that referenced this issue May 18, 2023
@nmm0
#2147: make getTracesSize() noexcept
41437d4
nmm0 added a commit that referenced this issue May 18, 2023
@nmm0
#2147: add functions for getting the number of trace events and the l…
cb50a14 
…ast trace event
nmm0 added a commit that referenced this issue May 18, 2023
@nmm0
#2147: if adding a memory event to begin/endProcessing, use the same …
f286d15 
…time as the processing event
nmm0 added a commit that referenced this issue May 18, 2023
@nmm0
#2147: cmake: add functionality to add --vt_trace to trace tests in c…
dc22536 
…test
nmm0 added a commit that referenced this issue May 18, 2023
@nmm0
#2147: cmake: add test to ensure timings are recorded correctly for c…
47a8f82 
…alls to start() and finish() trace runnable components
nmm0 added a commit that referenced this issue May 18, 2023
@nmm0
#2147: fix test file license
3c4d0e3
nmm0 added a commit that referenced this issue May 18, 2023
@nmm0
#2147: add documentation for added Trace functions
1921d59
nmm0 added a commit that referenced this issue May 18, 2023
@nmm0
#2147: fix some typos
f8a80b5
nlslatt added a commit that referenced this issue May 23, 2023
@nlslatt
Merge pull request #2148 from DARMA-tasking/2147-invalid-trace-timings
b89e422 
#2147: fix incorrect order of parameters for call to beginProcessing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2147: fix incorrect order of parameters for call to beginProcessing DARMA-tasking/vt
2 participants
@stmcgovern @nmm0